Add hotkey for Visual Diffs #6843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
haha cool.. I love this, and can't wait to try it out 👍 |
# Conflicts: # modules/svg/areas.js
quincylvania
added
new-feature
|
@Bonkles Thanks so much for this feature! It looks pretty good so I'm just merging as-is. I will tweak it somewhat but I just wanted to get it in there first 👍 |
quincylvania
added a commit
that referenced
this pull request
Oct 7, 2019
quincylvania
added a commit
that referenced
this pull request
Oct 7, 2019
…ing (re: #6843) Differentiate added lines and vertices from merely changed ones
quincylvania
added a commit
that referenced
this pull request
Oct 7, 2019
quincylvania
added a commit
that referenced
this pull request
Oct 8, 2019
Render tag-only diffs in yellow instead of translucent orange Don't use target colors for vertex diff styling
quincylvania
added a commit
that referenced
this pull request
Oct 8, 2019
|
So I iterated on the original design somewhat:
I think the results are good enough for now but I'm open to feedback and ideas! |
quincylvania
added a commit
that referenced
this pull request
Oct 10, 2019
Add Highlight Changes button to the Style Options section for toggling visual diffs (re: #6843)
|
I added a toggle button for this in the Map Data pane. This should make the feature more discoverable, escapable, and mobile-friendly.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new toggle hotkey (g) that highlights all unsaved edits on the screen.
Short video narrated by yours truly:
https://www.youtube.com/watch?v=Vo4q4D_Uo4o
It has support for lines, vertices, and areas, and when the 'G' key is pressed, green accent is drawn over/in the features in question. Generally tag edit highlights are lighter /lower opacity than geometry changes.
Light green denotes a tagging-only change, darker green indicates a geometry change.
Geometry changes supersede tagging changes, so if both are true for a particular entity, the geometry style will prevail.
I'm interested in feedback on the visual styles I employed to communicate the diff information as well as the color choice!