Text raw tag editor / Copy-paste tags #6302
Conversation
(Reverts: #6211, #5070, #5024) The old code allows users to circumvent the readonly tag protection see #6185 (comment) We'll offer a text-mode instead, with stricter checks on which keys can be modified.
(possibly re: #6289)
|
It works like this ✨
|
modules/ui/raw_tag_editor.js
Outdated
| .merge(textarea); | ||
|
|
||
| textarea | ||
| .attr('rows', rowData.length + 1) |
There was a problem hiding this comment.
Can we disable spell checking and autocorrect? Safari’s autocorrect is pretty aggressive inside textareas, and the 〰️ underlines get pretty annoying with raw tags.
There was a problem hiding this comment.
I dunno sometimes it does the right thing 
|
Does iD have code already that is able to resize the height of an textarea based on its content? (Like https://css-tricks.com/textarea-tricks/#article-header-id-6) I would not add it just for this element (it's quite a bit of JS just for this**), but if it only needs to be "activated" for this textarea, it would be nice for the last bit of the GIF where the text area has a scrollbar. |
|
Wow, happy to see any progress for (bulk) copy/paste function :-) Yes, maybe the window height could be increased a litte bit same time while when pasting the new lines? At that moment: |
keys or values can be quoted or unquoted: - leisure=park - leisure="park" - "leisure"=park - "leisure"="park"
|
This is good enough to merge now.. |
|
Some folks add new line characters in the description: https://www.openstreetmap.org/way/463013906 Would this work as is? |
Yep, that's handled in 16ec257 |
|
ok, looks good, newline got replaced by an I found one issue with two rows having the same key: one of them gets silently discarded when I switch back to the list. Merging them into one entry with semicolon as a separator might be an option, dunno. |
I think the preferred behavior would be to overwrite the old value, if any. |
It just keeps whichever is the last one in the list. I'm ok with this, since I'd expect people to paste their new values at the end of the list. |
|
Maybe change the blue and grey colour: (blue for clickable items, like "zoom to this" / "All fields" / "All tags")? |
Oh yeah, I was thinking about this too. I do like using a consistent blue for links. Maybe I could make it look more like these toggles we use elsewhere:
|
|
yes. Or (if there is not enough space) just one blue button, with remaining blue colour, but changing list icon <=> cursor icon? I'm not sure... edit: or something like a switch(blue of course): |
This change adds ability to toggle between the list view and a text view of tags, so that people can make faster tag edits or copy/paste tags.
closes #6185
closes #839