Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-translatable 131 strings for preset #6738

Closed
higa4 opened this issue Aug 10, 2019 · 7 comments
Closed

Un-translatable 131 strings for preset #6738

higa4 opened this issue Aug 10, 2019 · 7 comments
Labels
localization Adapting iD across languages, regions, and cultures

Comments

@higa4
Copy link

higa4 commented Aug 10, 2019

131 untranslated strings for the preset category appeared today that has no or few comment on transifex. Unable to translate these. https://www.transifex.com/openstreetmap/id-editor/dashboard/

@quincylvania
Copy link
Collaborator

Hi @higa4, the new strings are terms that we added for #5763. Similar to search terms for presets, these are search terms for fields. You can hover over the 1 tag to get more info:

Screen Shot 2019-08-11 at 11 49 15 AM

It isn't super helpful that this text is hidden in this way though. @bhousel What do you think of switching to [] brackets instead of <> to avoid this?

@higa4
Copy link
Author

higa4 commented Aug 12, 2019

OK, thanks.

@bhousel
Copy link
Member

bhousel commented Aug 12, 2019

dup of #4326
It's a good idea, but would potentially break a lot of existing translation work.

@bhousel bhousel closed this as completed Aug 12, 2019
@quincylvania
Copy link
Collaborator

dup of #4326

I was trying to find that 😅

It's a good idea, but would potentially break a lot of existing translation work.

True. Since we just added it for fields there's no better time to switch those over. Though I'm not sure it's worth losing all the great work done on the German and Japanese localizations over the weekend.

@quincylvania quincylvania added the localization Adapting iD across languages, regions, and cultures label Aug 12, 2019
@bhousel
Copy link
Member

bhousel commented Aug 12, 2019

True. Since we just added it for fields there's no better time to switch those over. Though I'm not sure it's worth losing all the great work done on the German and Japanese localizations over the weekend.

Wouldn't changing this break every terms translation going back 6 years?

@quincylvania
Copy link
Collaborator

@bhousel We could just change it for fields and not for presets. The terms for fields I just added last week.

@bhousel
Copy link
Member

bhousel commented Aug 12, 2019

Oh ok! It is probably good to try switching the field terms now and see how it works with brackets. Then if it's better, we can think about switching the preset terms and #4326 later. (For that - we can probably write a script to change and push the replacements to the transifex API so it doesn't just throw out everyone's old work).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization Adapting iD across languages, regions, and cultures
Projects
None yet
Development

No branches or pull requests

3 participants