Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directions from stop signs visualized on ways without highway tag. #9013

Closed
BubbaJuice opened this issue Mar 4, 2022 · 1 comment · Fixed by #10582
Closed

Directions from stop signs visualized on ways without highway tag. #9013

BubbaJuice opened this issue Mar 4, 2022 · 1 comment · Fixed by #10582
Labels
bug A bug - let's fix this! map-renderer An issue with how things are rendered in the map

Comments

@BubbaJuice
Copy link

URL

https://www.openstreetmap.org/edit#map=23/32.28756/-110.97337

How to reproduce the issue?

  1. Have a stop sign, tagged with direction on a highway node.
  2. Create an area or line that connects with the stop sign node.
    The issue should be present after following the two steps above.

Screenshot(s) or anything else?

When a stop sign (highway=stop) is tagged with a direction and a way or area without highway on it, the direction visualization is present. It is my belief that this should not be visualized on ways/areas without a highway tag.

The issue was present on the OSM website, RapiD, and the development version. I tested it on Firefox, Chrome, and Edge.
image

Which iD Editor versions do you see the issue on?

Released version at openstreetmap.org/edit, Development version at ideditor.netlify.com, RapiD version at mapwith.ai/rapid

Which browsers are you seeing this problem on?

Firefox, Chrome, Microsoft Edge

@1ec5
Copy link
Collaborator

1ec5 commented Dec 27, 2022

Whenever a node is tagged with a generic direction keyword such as forward or backward, the following code is responsible for inferring the direction from the node’s parent ways. For starters, it should be limited to parent ways that aren’t areas: #5634. But this would also be an opportunity to exclude some other things like (presumably) road markings:

iD/modules/osm/node.js

Lines 117 to 129 in 3dde091

resolver.parentWays(this).forEach(function(parent) {
var nodes = parent.nodes;
for (i = 0; i < nodes.length; i++) {
if (nodes[i] === this.id) { // match current entity
if (lookForward && i > 0) {
nodeIds[nodes[i - 1]] = true; // look back to prev node
}
if (lookBackward && i < nodes.length - 1) {
nodeIds[nodes[i + 1]] = true; // look ahead to next node
}
}
}
}, this);

@tyrasd tyrasd added map-renderer An issue with how things are rendered in the map bug A bug - let's fix this! labels Dec 3, 2024
tyrasd added a commit that referenced this issue Dec 4, 2024
for certain vertex features, only look at matching parent ways when determining where to draw direction cones:

* highway related points (e.g. highway=stop/yield/etc., traffic calming, cycleway=asl, traffic signs, barriers): only look at parent ways with highway=*
* railway related points (e.g. railway=milestone): only look at parent ways with railway=*
* waterway related points (e.g. waterway=milestone): only look at parent ways with waterway=*

see also #5634
tyrasd added a commit that referenced this issue Dec 11, 2024
for certain vertex features, only look at matching parent ways when determining where to draw direction cones:

* highway related points (e.g. highway=stop/yield/etc., traffic calming, cycleway=asl, traffic signs, barriers): only look at parent ways with highway=*
* railway related points (e.g. railway=milestone): only look at parent ways with railway=*
* waterway related points (e.g. waterway=milestone): only look at parent ways with waterway=*

see also #5634
@tyrasd tyrasd closed this as completed in 3be7eb6 Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this! map-renderer An issue with how things are rendered in the map
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants