Restrict direction cones to matching parent ways #10582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyrasd
force-pushed
the
direction-cones-restrict
branch
from
b6dc762 to
d77804a
Compare
for certain vertex features, only look at matching parent ways when determining where to draw direction cones: * highway related points (e.g. highway=stop/yield/etc., traffic calming, cycleway=asl, traffic signs, barriers): only look at parent ways with highway=* * railway related points (e.g. railway=milestone): only look at parent ways with railway=* * waterway related points (e.g. waterway=milestone): only look at parent ways with waterway=* see also #5634
tyrasd
force-pushed
the
direction-cones-restrict
branch
from
d77804a to
3be7eb6
Compare
bhousel
added a commit
to facebook/Rapid
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9013: For certain vertex features, only look at matching parent ways when determining where to draw direction cones:
highway=stop/yield/…, traffic calming,cycleway=asl, traffic signs, barriers): only look at parent ways withhighway=*railway=milestone): only look at parent ways withrailway=*waterway=milestone): only look at parent ways withwaterway=*These cases cover all presets in iD that currently use the
direction_vertexfield. Are there any further feature combinations to consider?