Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show MJS photo attribution #5137

Merged
merged 1 commit into from
Jul 16, 2018

Conversation

kratico
Copy link
Contributor

@kratico kratico commented Jul 12, 2018

No description provided.

@kratico kratico closed this Jul 12, 2018
@kratico kratico reopened this Jul 13, 2018
@kratico kratico changed the title Remove OSM iD custom photo attribution to show MJS photo attribution Show MJS photo attribution Jul 13, 2018
@bhousel
Copy link
Member

bhousel commented Jul 13, 2018

Hmm we had a reason for this in #4526 which was closed by 1dd437a
I think the reason was because at the time the built-in viewer attribution did not display the capture date, and we weren't able to reliably update it with d3.js.

Do we lose anything by switching back to the built-in viewer attribution? (I'm ok with switching back but I would want to know the difference).

@kratico
Copy link
Contributor Author

kratico commented Jul 15, 2018

The built in viewer displays a compact attribution if the viewer size is less than 640px.
With #5138 the viewer can be resized and a non-compact attribution is displayed.

MJS non-compact attribution
image

MJS compact attribution
image

Current attribution overlaps with MJS built in attribution
image

I think that the UX is better with the built in attribution, and the only difference it that MJS built in attribution does not show the time.

@bhousel
Copy link
Member

bhousel commented Jul 15, 2018

Nice thanks for screenshots, I agree the built in attribution is an improvement 👍

@bhousel bhousel merged commit edc4f86 into openstreetmap:master Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants