Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to resize to PhotoViewer #4930 #5138

Merged
merged 2 commits into from
Jul 17, 2018

Conversation

kratico
Copy link
Contributor

@kratico kratico commented Jul 13, 2018

Related to #4930

@bhousel Could you check how to resize Bing StreetSide?

@bhousel
Copy link
Member

bhousel commented Jul 13, 2018

This looks awesome, I'll check it out today..

@cbeddow
Copy link
Contributor

cbeddow commented Jul 17, 2018

Following this to see when it's merged

@bhousel
Copy link
Member

bhousel commented Jul 17, 2018

Thanks for this @kratico & @cbeddow - I made a few slight changes and just merged it:

  • added resize for OpenStreetCam and Bing Streetside
  • prevent resize up from exceeding the size of the map window
  • when map resizes down, shrink photo viewer if needed
  • slightly increased the size of the resize handle buttons

It's really awesome! 👏

mapillary resize

@tordans
Copy link
Collaborator

tordans commented Aug 6, 2018

@bhousel the resize does not seem to work for me at https://www.openstreetmap.org/edit#map=20/52.47332/13.44890

Screenshot:
bildschirmfoto 2018-08-06 um 11 25 42

Operating System Mac OSX 10
Web Browser Chrome 69.0.3494

Am I doing it wrong?

@bhousel
Copy link
Member

bhousel commented Aug 6, 2018

Am I doing it wrong?

It looks right to me- @tordans if you open the developer console, do you see any warnings?

It does look like you are using the webgl viewer (there is a fallback option if webgl were not working, but I think it would render differently in this case).

@tordans
Copy link
Collaborator

tordans commented Aug 6, 2018

I re-tested it with some browsers, now it is working with all. I don't know why it did't before. Thanks for the help and the feature!

@bhousel
Copy link
Member

bhousel commented Aug 6, 2018

I re-tested it with some browsers, now it is working with all. I don't know why it did't before. Thanks for the help and the feature!

good to hear, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants