Support building=manufacture with dedicated building description

[matkoniecz]

See https://wiki.openstreetmap.org/wiki/Tag%3Abuilding%3Dmanufacture

Found via streetcomplete/StreetComplete#4194

[peternewman]

What is the distinction between industrial and manufacture? Even the wiki doesn't really clarify!

It's also missing from https://wiki.openstreetmap.org/wiki/Key:building

[tyrasd]

I'm hesitating slightly because the tag usage stagnates since 2015, as seen in this graph:

Maybe it should be included as a hidden (searchable=false) preset?

[matkoniecz]

searchable=false also looks like a good idea to me

In many cases it was fueled by imports and distinction is tiny.

Hmm, is it possible to declare it as a synonym of building=industrial to avoid adding one more string to translate?

[tyrasd]

Hmm, is it possible to declare it as a synonym of building=industrial

Unfortunately, not really. The closest thing would be to add a deprecation rule building=manufacture to building=industrial. But at first glance, I think that would probably not be appropriate for this tag right now.

[matkoniecz]

Then I added "searchable": false

No matter what is the source, I think that about 100k buildings deserves a label.

[matkoniecz]

BTW, I am considering reviewing other buildings values for missing labels: would you be happy to get other similar PRs for valid building types with say >100 000 occurrences?

[tyrasd]

100k occurences sounds reasonable. 👍 I'd prefer if you could do a single pull request for all of the missing types, but if you prefer to do it individually, that's also ok.

[matkoniecz]

Building scan found outbuilding and allotment_house (if anyone wants: feel free to make PR if you find good descriptions for this values)

@tyrasd Would you be interested in such listing for say shop amenity barrier leisure natural (with adjusted thresholds)?

I believe that JOSM has similar script that is listing popular tags (keys?) and they maintain list of popular tags which are deliberately not supported.

[tyrasd]

@tyrasd Would you be interested in such listing for say shop amenity barrier leisure natural (with adjusted thresholds)?

👍

I believe that JOSM has similar script that is listing popular tags (keys?) and they maintain list of popular tags which are deliberately not supported.

I'd be interested to learn more about how they do this

[matkoniecz]

@tyrasd For JOSM see https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/ignoretags.cfg (permalink: https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/ignoretags.cfg?rev=18250 ) and https://josm.openstreetmap.de/ticket/21396