-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add translatable strings to kerb
field
#1029
Conversation
🍱 Preview the tagging presets of this pull request here: https://pr-1029--ideditor-presets-preview.netlify.app/id/dist/#locale=en. |
Hi @tyrasd, would you be able to review this pr? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs a little bit more polish, to be honest. Here are a few thoughts:
- A new mapper will not really know the concrete distinctions between flush and lowered and raised. That should be made discoverable, at least in form of tooltips, e.g.
… "strings": { "options": { "lowered": { "title": "Lowered", "description": "A dropped curb which can be used by wheelchair users, not higher than a few centimeters." }, … } }, … ```
- the values
yes
andno
are not really applicable in the preset forbarrier=kerb
(yes
would be redundant, andno
would be a contradiction). These values would however potentially make some sense when the tag is used as a property of ahighway=crossing
node. Currently, the presets share the samekerb
field, but when we add the options, the field would need to be duplicated for the two cases: one with all options (for the crossing preset) and one withoutyes
/no
(for the kerb presets).
How should the corresponding json files be named? And should the field for the kerb preset go into the .../fields/kerb/ subfolder? |
I would mimic the way we did this for the different
|
Thanks, this looks good now! |
No description provided.