Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translatable strings to kerb field #1029

Merged
merged 12 commits into from
Feb 17, 2024
Merged

Conversation

kjonosm
Copy link
Contributor

@kjonosm kjonosm commented Oct 15, 2023

No description provided.

@github-actions
Copy link

🍱 Preview the tagging presets of this pull request here: https://pr-1029--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

@kjonosm
Copy link
Contributor Author

kjonosm commented Feb 11, 2024

Hi @tyrasd, would you be able to review this pr?

Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs a little bit more polish, to be honest. Here are a few thoughts:

  • A new mapper will not really know the concrete distinctions between flush and lowered and raised. That should be made discoverable, at least in form of tooltips, e.g.
    
    "strings": {
        "options": {
            "lowered": {
                "title": "Lowered",
                "description": "A dropped curb which can be used by wheelchair users, not higher than a few centimeters."
            },
            
        }
    }, 
    ```
  • the values yes and no are not really applicable in the preset for barrier=kerb (yes would be redundant, and no would be a contradiction). These values would however potentially make some sense when the tag is used as a property of a highway=crossing node. Currently, the presets share the same kerb field, but when we add the options, the field would need to be duplicated for the two cases: one with all options (for the crossing preset) and one without yes/no (for the kerb presets).

@kjonosm
Copy link
Contributor Author

kjonosm commented Feb 17, 2024

one with all options (for the crossing preset) and one without yes/no (for the kerb presets).

How should the corresponding json files be named? And should the field for the kerb preset go into the .../fields/kerb/ subfolder?

@tyrasd
Copy link
Member

tyrasd commented Feb 17, 2024

I would mimic the way we did this for the different sport fields (see e.g. sport_racing_motor.json for an example) and use these files:

  • keep the existing kerb.json with all strings/options in the root directory data/fields
  • a file kerb_barrier.json in the subfolder in the subdirectory data/fields/kerb/

@tyrasd tyrasd merged commit 0d31467 into openstreetmap:main Feb 17, 2024
5 checks passed
@tyrasd
Copy link
Member

tyrasd commented Feb 17, 2024

Thanks, this looks good now!

@kjonosm kjonosm deleted the patch-45 branch February 17, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants