-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kerb: Update name of general preset #1077
Conversation
🍱 You can preview the tagging presets of this pull request here. |
We used In general, in such situations it would be better to create a dedicated icon for the generic case, as that would also be show up distinctively on the map. Maybe the existing icon with a question mark instead of the arrow would be an option? |
ok, thinking about it again: I'd say that adding a "suffix" to the preset name is not adding too much value: I would say that most data consumers treat unspecified kerbs as full height ones, and mappers are asked to choose a specific type1 in the preset field. Also, we currently only use the In general, a dedicated icon would be the optimal solution. I've opened rapideditor/temaki#90 for that. Feedback welcome. 😉 Footnotes
|
specialized presets should be switched using the preset selector, no need to duplicate that as a combo box. this effectively reverts openstreetmap/iD#6360 (re icons, see also #1077 (comment)) also remove duplicates of translatable strings
89139bb switches to the new temaki icon. I'd say this addresses the original issue sufficiently well that we can close this PR. 😊 |
The preset that represents an "unspecified" kerb looks the same as the more specified presets.
We started using some term to signal that this is the general preset but there are more precise once, but I could not find it just now… — Do we have a way to add wording to those general presets, already?
We could also change the icon, but I don't see anything obvious and easy to do.
This is what it looks ATM.