Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kerb: Update name of general preset #1077

Closed
wants to merge 1 commit into from

Conversation

tordans
Copy link
Collaborator

@tordans tordans commented Dec 28, 2023

The preset that represents an "unspecified" kerb looks the same as the more specified presets.

We started using some term to signal that this is the general preset but there are more precise once, but I could not find it just now… — Do we have a way to add wording to those general presets, already?

We could also change the icon, but I don't see anything obvious and easy to do.

This is what it looks ATM.

image

Copy link

🍱 You can preview the tagging presets of this pull request here.

@tyrasd tyrasd added the new-label changes the name, aliases or terms of a preset label Jan 17, 2024
@tyrasd
Copy link
Member

tyrasd commented Jan 17, 2024

Do we have a way to add wording to those general presets, already?

We used … (Unspecified Type) in a few places (e.g. barrier/_yes.json).

In general, in such situations it would be better to create a dedicated icon for the generic case, as that would also be show up distinctively on the map. Maybe the existing icon with a question mark instead of the arrow would be an option?

@tyrasd tyrasd added this to the v6.7 milestone Jan 24, 2024
@tyrasd
Copy link
Member

tyrasd commented Feb 27, 2024

ok, thinking about it again: I'd say that adding a "suffix" to the preset name is not adding too much value: I would say that most data consumers treat unspecified kerbs as full height ones, and mappers are asked to choose a specific type1 in the preset field. Also, we currently only use the … (Unspecified Type) for unsearchable presets of tags which are generally discouraged to use (like the mentioned barrier=yes).

In general, a dedicated icon would be the optimal solution. I've opened rapideditor/temaki#90 for that. Feedback welcome. 😉

Footnotes

  1. what would help here is that the kerb field would have translatable names (Add translatable strings to kerb field #1029) and show the icons for the documented types, though.

@tyrasd tyrasd added new-icon waitfor-icon a matching icon is missing for this preset and removed new-label changes the name, aliases or terms of a preset labels Feb 27, 2024
@tyrasd tyrasd modified the milestones: v6.7, v6.8 Feb 27, 2024
tyrasd added a commit that referenced this pull request Feb 27, 2024
specialized presets should be switched using the preset selector, no need to duplicate that as a combo box. this effectively reverts openstreetmap/iD#6360

(re icons, see also #1077 (comment))

also remove duplicates of translatable strings
tyrasd added a commit that referenced this pull request Mar 14, 2024
@tyrasd
Copy link
Member

tyrasd commented Mar 14, 2024

89139bb switches to the new temaki icon. I'd say this addresses the original issue sufficiently well that we can close this PR. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-icon waitfor-icon a matching icon is missing for this preset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants