Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regional Preset: highway=path for foot+bicycle in Israel #1062

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

zstadler
Copy link
Contributor

In #1058 the Israel was excluded from the system default of using highway=cycleway for "foot+bicycle" paths.

The goal of this PR is to create an Israel-specific preset of using highway=path for "foot+bicycle" paths.

It is based on the global presets and adds MTB-related tags which are recommended in Israel.

Please let me know if additional files are needed as part of this PR.

Copy link

🍱 Preview the tagging presets of this pull request here: https://pr-1062--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

@zstadler zstadler marked this pull request as draft November 23, 2023 13:36
@zstadler zstadler marked this pull request as ready for review November 23, 2023 14:19
@westnordost
Copy link
Contributor

Regional presets are a really bad idea. See ideditor/schema-builder#94

@zstadler
Copy link
Contributor Author

@westnordost,

This "regional" preset is about the addTags

"addTags": {
"highway": "path",
"foot": "designated",
"bicycle": "designated"
},

that differs from the "global" preset

"addTags": {
"highway": "cycleway",
"foot": "designated",
"bicycle": "designated"
},

Potentially, other regions, such a France and Germany, would like to join using it...

"exclude": [
"fr",
"lt",
"pl",
"de",
"il",
"ps"
]

as it simply implements the wiki-recommended tagging for foot+bicycle path.

@tyrasd tyrasd added this to the v6.6 milestone Dec 15, 2023
@tyrasd tyrasd modified the milestones: v6.6, v6.7 Jan 24, 2024
@tyrasd tyrasd modified the milestones: v6.7, v6.8 Mar 13, 2024
@tordans
Copy link
Collaborator

tordans commented Jul 6, 2024

I might be missing something here … but we could just add the mtp fields as moreFields on the existing present, right?

Or, if that is not ideal, that add the fields there but move the regional filter to the field, like it was done in ae68fee which is related to the linked issue.

Copy link
Collaborator

@tordans tordans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just adds a formal PR status (see previous comment).

@hlfan
Copy link

hlfan commented Dec 1, 2024

#1384 is presumably the better version for this tagging variant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants