-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regional Preset: highway=path for foot+bicycle in Israel #1062
base: main
Are you sure you want to change the base?
Conversation
6986784
to
5725434
Compare
🍱 Preview the tagging presets of this pull request here: https://pr-1062--ideditor-presets-preview.netlify.app/id/dist/#locale=en. |
Regional presets are a really bad idea. See ideditor/schema-builder#94 |
This "regional" preset is about the id-tagging-schema/data/presets/highway/path/bicycle_foot-IL.json Lines 32 to 36 in 92fffaa
that differs from the "global" preset id-tagging-schema/data/presets/highway/cycleway/bicycle_foot.json Lines 31 to 35 in 92fffaa
Potentially, other regions, such a France and Germany, would like to join using it... id-tagging-schema/data/presets/highway/cycleway/bicycle_foot.json Lines 3 to 10 in 9591d85
as it simply implements the wiki-recommended tagging for foot+bicycle path. |
I might be missing something here … but we could just add the mtp fields as moreFields on the existing present, right? Or, if that is not ideal, that add the fields there but move the regional filter to the field, like it was done in ae68fee which is related to the linked issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just adds a formal PR status (see previous comment).
#1384 is presumably the better version for this tagging variant. |
In #1058 the Israel was excluded from the system default of using
highway=cycleway
for "foot+bicycle" paths.The goal of this PR is to create an Israel-specific preset of using
highway=path
for "foot+bicycle" paths.It is based on the global presets and adds MTB-related tags which are recommended in Israel.
Please let me know if additional files are needed as part of this PR.