Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add presets for highway=path-based cycle-footway tagging #1384

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

olafkryus
Copy link
Contributor

@olafkryus olafkryus commented Nov 6, 2024

Description, Motivation & Context

Some of the regions are opted out of the cycle-footway preset currently available in iD, since the preset insists on using the highway=cycleway tag, but those communities accepted the use of highway=path tag as their consensus on tagging the feature. Yet no alternative preset is available, therefore in these regions, those cycle-footways are displayed in iD in same way as regular path, with no way to apply any preset, neither cycleway nor path-based one. This PR aims to fill the gap.

Related issues

Copy link

github-actions bot commented Nov 6, 2024

🍱 You can preview the tagging presets of this pull request here.

@matkoniecz
Copy link
Contributor

Partially resolves

will it cause github to close linked issue? maybe put "resolves (partially)" ?

@tordans
Copy link
Collaborator

tordans commented Nov 6, 2024

FYI: There is a big refactoring on crossings as a PR that I am waiting for to be merged for a long while now.

@tordans
Copy link
Collaborator

tordans commented Dec 2, 2024

FYI: There is a big refactoring on crossings as a PR that I am waiting for to be merged for a long while now.

FYI this was merged recently. Could you rebase your PR?

@olafkryus
Copy link
Contributor Author

Partially resolves

will it cause github to close linked issue? maybe put "resolves (partially)" ?

@matkoniecz Actually yes it would, which we do not want, thanks for pointing that out. Reworded to "Partially overlaps with" so it won't happen.

FYI: There is a big refactoring on crossings as a PR that I am waiting for to be merged for a long while now.

FYI this was merged recently. Could you rebase your PR?

@tordans Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cycle & Foot Path preset missing from search results in France New preset: Cycle & Foot Path for Europe
3 participants