Add presets for highway=path-based cycle-footway tagging

[olafkryus]

Description, Motivation & Context

Some of the regions are opted out of the cycle-footway preset currently available in iD, since the preset insists on using the highway=cycleway tag, but those communities accepted the use of highway=path tag as their consensus on tagging the feature. Yet no alternative preset is available, therefore in these regions, those cycle-footways are displayed in iD in same way as regular path, with no way to apply any preset, neither cycleway nor path-based one. This PR aims to fill the gap.

Related issues

• Closes New preset: Cycle & Foot Path for Europe #109
• Partially overlaps with Add regional presets for german cycleway tagging #267
• Partially overlaps with Preset for a way designated for both cyclists and pedestrians, without separate spaces (segregated=no) #317
• Closes Cycle & Foot Path preset missing from search results in France #759
• Partially overlaps with Do not enforce Cycle & Foot Path or Cycle & Foot Crossing in Norway #1193
• Partially overlaps with Treat presets with locationSet.exclude as unsearchable presets with low score instead of hiding them #1205

[github-actions]

🍱 You can preview the tagging presets of this pull request here.

[matkoniecz]

Partially resolves

will it cause github to close linked issue? maybe put "resolves (partially)" ?

[olafkryus]

I've also now added Norway to the inclusion and exclusion country lists in the presets concerned, as per #1193, since those country lists should be identical between those presets, and since #1193 ( which seems to have been "forgotten" for some reason? 🤷‍♂️ ) is covering roughly the same issue. So if this PR is deemed to be good to go, I guess #1193 should be merged first, in order to have correct contributor attributions in main repo.

[tordans]

@olafkryus please use the test template to add some test cases to this PR https://github.com/openstreetmap/id-tagging-schema/blob/main/.github/PULL_REQUEST_TEMPLATE.md?plain=1#L24-L70

I also commented on #1193 (comment) and you might have an opinion on this.

TBH I am not sure that adding the regional preset changes to this PR will lead to this one being merged sooner. It might be better to keep those things separated.

[tordans]

@olafkryus

TBH I am not sure that adding the regional preset changes to this PR will lead to this one being merged sooner. It might be better to keep those things separated.

Given how the conversation went in #1193 I would like to tune back this PR to only include the added preset (and maybe the missing "de" https://github.com/openstreetmap/id-tagging-schema/pull/1384/files#diff-3b8f616654b5d2845f63eb05ce32b27741d3945ad0a71e55033de12a656d8b56R7)

I would consider this ready for merge then. But we still should check the test checklist first.

[olafkryus]

Test-Documentation

Preview links & Sidebar Screenshots

Icons are copied, and fields are directly re-used from already existing related highway=cycleway-based tagging presets.

Bicycle & Foot Path

https://pr-1384--ideditor-presets-preview.netlify.app/id/dist/#background=Geoportal2-PL-aerial_image_WMTS&disable_features=boundaries&id=w991414746&locale=en&map=20.22/50.26270/19.00850

Bicycle & Foot Crossing

https://pr-1384--ideditor-presets-preview.netlify.app/id/dist/#background=Geoportal2-PL-aerial_image_WMTS&disable_features=boundaries&id=w699046787&locale=en&map=20.22/50.26270/19.00850

Search

Info-i

Bicycle & Foot Path

Bicycle & Foot Crossing

Wording

New presets directly re-use all wording from already existing related highway=cycleway-based tagging presets.

[olafkryus]

@tordans If I had paid a bit more attention to the description of #1193, I probably would have noticed that it's similarly-looking solution is actually an unexpected method of trying to solve a bit different problem. 🫥 Whether cycleway is implying bicycle designation is quite a good point, but certainly for another issue. (on the bright side, at least that moved forward a bit 😉 ). For now, it's Norway-out from the country lists here.

Test Documentation added.

[tordans]

It's great to have this in place, now. Looking at it on the map makes me hope we will find a good solution for openstreetmap/iD#10256 which would resolve the rendering issue of those shared path lines. — Maybe you have an idea over there @olafkryus

[tordans]

Documentation:

The info-i part is a bit unfortunate but I don't see any way to reference a wiki page that will show something with a more to the point meaning. It is all very generic hw=path and not what we would want to see here like "shared bike and pedestrian path/crossing, segregated or not".

When I switch from a shared path to a cycle path and back via presets the "segregated=*" value gets lost. But I think that is OK for this use case.

Search looks good

[1ec5]

The info-i part is a bit unfortunate but I don't see any way to reference a wiki page that will show something with a more to the point meaning. It is all very generic hw=path and not what we would want to see here like "shared bike and pedestrian path/crossing, segregated or not".

That’s a known issue with the tagging scheme overall. I’m not sure we can reasonably expect a single brief description that covers the tag’s multiple personalities. There are too many relevant forum threads to list here, but here are a few off the top of my head:

• RfC: Reorder samples in highway=path documentation
• Request for Comments: Solution proposal for the path issues
• Documenting the problems with highway=path
• Mapping combined ways for cycling and walking

[tordans]

@1ec5 I was thinking along the lines of …

• find a way to model a wiki data item for a tag combination and use that as reference for a preset –> AFAIK that is not part of the wiki data item setup at this point
• have an optional hard coded info-i text here in the code –> this could get messy and would move more responsibility here which I don't think is worth the effort at this point

The reference cannot help here due the lack of a specific tag…

[1ec5]

The data item’s description already has a disclaimer in English and possibly some other languages that would be affected by this preset. Maybe the disclaimer could say that the tag is not just unspecific but overloaded with multiple meanings, so the user should read the full documentation for details.