Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add presets for pedestrian crossings with traffic signals for lines #368

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

Dimitar5555
Copy link
Contributor

No description provided.

@tyrasd
Copy link
Member

tyrasd commented Jan 24, 2022

Thanks!

PS: for reference: this complements the vertex-preset added in #192

@tyrasd tyrasd merged commit 7fd94a0 into openstreetmap:main Jan 24, 2022
@1ec5
Copy link
Contributor

1ec5 commented Jun 21, 2022

Somehow the terms for the traffic calming version of this preset wound up in the non–traffic calming version:

"name": "Crossing With Pedestrian Signals",
"terms": [
"pedestrian traffic lights",
"pedestrian traffic signals",
"pedestrian crossing (lights)",
"bicycle crossing (lights)",
"crosswalk (lights)",
"flat top",
"hump",
"speed",
"slow"
]

@tyrasd
Copy link
Member

tyrasd commented Jun 21, 2022

traffic calming version

what version do you mean, exactly? after 4644b46 there should be no more "traffic calming" versions of the crossing presets.

@1ec5
Copy link
Contributor

1ec5 commented Jun 22, 2022

traffic_calming=table-related terms like “hump” should be terms of the Raised field, not the crossing presets. #508 would move the terms to the correct place. (I should’ve posted the above comment to 4644b46, not this issue.)

@tyrasd
Copy link
Member

tyrasd commented Jun 22, 2022

Ah, I see. That's now fixed in 3da4577, thanks for the hint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants