Clean up crossing preset terms #508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These terms only made sense for the raised crossing presets, which got merged with the unraised crossing presets.
tyrasd
pushed a commit
that referenced
this pull request
Jun 22, 2022
Squashed commit of the following: commit d49ade3 Author: Minh Nguyễn <mxn@1ec5.org> Date: Wed Jun 22 01:58:14 2022 -0700 Added table terms to Raised field commit b29faf0 Author: Minh Nguyễn <mxn@1ec5.org> Date: Wed Jun 22 01:48:00 2022 -0700 Renamed crossing=traffic_signals presets to correct name commit fe3caad Author: Minh Nguyễn <mxn@1ec5.org> Date: Wed Jun 22 01:37:45 2022 -0700 Removed table-related terms from crossing presets These terms only made sense for the raised crossing presets, which got merged with the unraised crossing presets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved terms related to
traffic_calming=tablefrom the “Unmarked Crossing”, “Marked Crosswalk”, and “Crossing With Pedestrian Signals” presets to the “Raised” field. These terms only made sense for the raised crossing presets, which got merged with the unraised crossing presets in 4644b46 along with introducing the “Raised” field./ref #368 (comment)