-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to iD v2.17.0 #2474
Update to iD v2.17.0 #2474
Conversation
vendor/assets/iD/iD.css.erb
Outdated
@@ -774,6 +789,10 @@ path.fill.tag-power-plant { | |||
path.stroke.tag-natural-wetland { | |||
stroke: rgb(153, 225, 170); | |||
} | |||
path.fill.tag-natural-wetland { | |||
stroke: rgb(153, 225, 170, 0.3); | |||
fill: rgb(153, 225, 170, 0.3); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two lines are causing a test failure - should they be rgba
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I updated those lines.
path.fill.tag-landuse-orchard, | ||
path.fill.tag-landuse-vineyard { | ||
stroke: rgb(191, 232, 63, 0.3); | ||
fill: rgb(191, 232, 63, 0.3); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those two lines also need to be changed from rgb to rgba, as they cause test failures similar to above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. this is already fixed in openstreetmap/iD@acfd1af, but I don't seem to find the fix for natural-wetland upstream (https://github.com/openstreetmap/iD/blob/master/css/25_areas.css#L197-L198). Somehow those two fixes are now a bit mixed up between repos. 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmd-osm Okay thanks, I just fixed this on that branch too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok thanks! Will you create another PR for this repo that fixes vineyards?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhhh I wasn't reading carefully and didn't realize there were two separate issues here 😂
Will fix now.
Preview this release. (Deployment may be delayed, check version number in bottom right)
2.17.0
2019-Dec-23
📰 News
📣 Release Highlights
Find the "Add a bridge" and "Add a tunnel" fixes for each crossing in the Issues inspector.
Select a few large features and press Z to view their full extent, no matter how vast.
Press P to view privacy preferences.
💥 Breaking Changes
🎉 New Features
✨ Usability
demolished:building=yes
landuse=village_green
areas in green (#7011)✅ Validation
waterway=fish_pass
not:brand:wikidata
tag to silence nonstandard brand warnings (#6577)natural=cape
oramenity=vending_machine
on vertices as mismatched geometry (#6982, #6515)oneway=yes
tohighway=motorway_link
by default (#7013)junction
tag to imply a feature should be an area (#6933)aerialway=station
instead ofaerialway=yes
for aerialway stations (#6994)crossing=zebra
(#6962)amenity=social_club
andleisure=social_club
(#6252)agrarian=agrcultural_machinry
misspelling (#7053)company=consulting
,office=consultancy
,office=consultant
,shop=consulting
type=audio
,type=video
,type=caldera
,type=extinct
,type=scoria
,type=shield
,type=strato
,type=extinct
amenity=research_institution
,barrier=railing
,craft=glass
,man_made=gas_well
,man_made=oil_well
,man_made=village_pump
,power=marker
🐛 Bugfixes
area=yes
to nodes when using the Extract operation on areas (#7057)🌏 Localization
⌛ Performance
🎓 Walkthrough / Help
🚀 Presets
network
to "Network Class"network:type
to Route presets with anetwork
valueflag:type=national
(#7099)religion=none
(#7135)