Add early failure for too old macOS, XCode or target macOS version#678
Merged
macumber merged 2 commits intoopenstudiocoalition:developfrom Feb 5, 2024
Merged
Conversation
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
mduvanel
force-pushed
the
add-macos-early-failure
branch
from
ff6fcdf to
eea0628
Compare
macumber
reviewed
Feb 4, 2024
mduvanel
force-pushed
the
add-macos-early-failure
branch
from
10667fb to
b835b93
Compare
macumber
approved these changes
Feb 5, 2024
Collaborator
|
I will merge once CI completes, thanks! |
Contributor
Author
Thank you for the quick turnaround! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qt6 mandates to target macOS 11.0 or greater, but also to have XCode 13 or greater to compile. See this explicit error from the
lreleaseutility using XCode 12 on macOS 10.15.7:This PR adds early checks for these hard requirements.