Skip to content

Add early failure for too old macOS, XCode or target macOS version #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
macumber merged 2 commits into from
Feb 5, 2024
Merged

Add early failure for too old macOS, XCode or target macOS version #678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eea0628
Add early failure for too old macOS, XCode or target macOS version
mduvanel Feb 2, 2024
b835b93
Bump MACOSX_DEPLOYMENT_TARGET version on CI
mduvanel Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/app_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ jobs:
COMPRESSED_EXT: tar.gz
BINARY_PKG_PATH: _CPack_Packages/Darwin/IFW
COMPRESSED_PKG_PATH: _CPack_Packages/Darwin/TGZ
MACOSX_DEPLOYMENT_TARGET: 10.15
MACOSX_DEPLOYMENT_TARGET: 11.0
SDKROOT: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk
QT_OS_NAME: mac
QT_ARCH: clang_64
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/manual_cli_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
PLATFORM_NAME: Darwin
BINARY_EXT: dmg
COMPRESSED_EXT: tar.gz
MACOSX_DEPLOYMENT_TARGET: 10.15
MACOSX_DEPLOYMENT_TARGET: 11.0
- os: macos-arm64
SELF_HOSTED: true
PLATFORM_NAME: Darwin
Expand Down
14 changes: 14 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,21 @@ if(APPLE)
# Looking at cmake source code OS_RELEASE is already set to the output of `sw_vers -productVersion` which is what we want
cmake_host_system_information(RESULT OSX_VERSION QUERY OS_RELEASE)
message("-- OS_RELEASE variable is set to: " ${OSX_VERSION})

if(DEFINED XCODE_VERSION)
if(XCODE_VERSION VERSION_LESS "13.0")
message(FATAL_ERROR "The minimum required version of XCode for compiling OpenStudio is 13, however XCODE_VERSION is set to " ${XCODE_VERSION} ". Please upgrade XCode and try again.")
endif()
# When using a generator other than XCode, ${XCODE_VERSION} is not set. Verify that we have at least the minimum macOS version required for XCode 13
elseif(OSX_VERSION VERSION_LESS "11.3")
message(FATAL_ERROR "The minimum required version of XCode for compiling OpenStudio is 13, which requires macOS 11.3 or greater, however macOS version is set to " ${OSX_VERSION} ". Please upgrade macOS and XCode and try again.")
endif()

if(NOT CMAKE_OSX_DEPLOYMENT_TARGET STREQUAL "")
if(CMAKE_OSX_DEPLOYMENT_TARGET VERSION_LESS "11.0")
message(FATAL_ERROR "The minimum required target version for macOS is 11.0, however CMAKE_OSX_DEPLOYMENT_TARGET is set to ${CMAKE_OSX_DEPLOYMENT_TARGET}. Please set CMAKE_OSX_DEPLOYMENT_TARGET to 11.0 or greater and try again.")
endif()

message("Using CMAKE_OSX_DEPLOYMENT_TARGET=${CMAKE_OSX_DEPLOYMENT_TARGET}")
set(OSX_VERSION "${CMAKE_OSX_DEPLOYMENT_TARGET}")
endif()
Expand Down