fix: use temp uri to build storage path while workspace is undefined #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v2.13.x #210 +/- ##
===========================================
- Coverage 59.41% 59.41% -0.01%
===========================================
Files 1180 1180
Lines 72335 72332 -3
Branches 14972 14971 -1
===========================================
- Hits 42977 42974 -3
Misses 26756 26756
Partials 2602 2602
Continue to review full report at Codecov.
|
Aaaaash
approved these changes
Dec 27, 2021
erha19
deleted the
fix/storage-path/resolve-correct-storage-path-while-workspace-is-null
branch
erha19
added a commit
that referenced
this pull request
Dec 28, 2021
* feat: support component cdn type configuration (#154) * feat: support component cdn type configuration * chore: add release branch to workflow * chore: fix lint error * chore: 2.13.2 * fix: set correct component cdn url (#158) * chore: 2.13.3 * fix: editor save issue (#189) * chore: 2.13.4 * fix: use temp uri to build storage path while workspace is undefined (#210) * chore: 2.13.5 * fix: theme fallback logic (#220) * fix: add ExtensionDidContributes event for themes (#214) * fix: remove theme fallback logic (#188) * chore: 2.13.6 Co-authored-by: 大表哥 <xubing.bxb@alibaba-inc.com>
erha19
added a commit
that referenced
this pull request
Dec 29, 2021
* feat: support component cdn type configuration (#154) * feat: support component cdn type configuration * chore: add release branch to workflow * chore: fix lint error * chore: 2.13.2 * fix: set correct component cdn url (#158) * chore: 2.13.3 * fix: editor save issue (#189) * chore: 2.13.4 * fix: use temp uri to build storage path while workspace is undefined (#210) * chore: 2.13.5 * fix: theme fallback logic (#220) * fix: add ExtensionDidContributes event for themes (#214) * fix: remove theme fallback logic (#188) * chore: 2.13.6 Co-authored-by: 大表哥 <xubing.bxb@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
while
workspaceDiris undefined, the storage path will use fallback.sumipathChangelog
use temp uri to build storage path while workspace is undefined