Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove theme fallback logic #188

Merged
merged 1 commit into from
Dec 24, 2021
Merged

Conversation

Aaaaash
Copy link
Member

@Aaaaash Aaaaash commented Dec 22, 2021

变动类型

  • 日常 bug 修复

需求背景和解决方案

changelog

  • 去掉多余的主题 fallback 逻辑

@codecov-commenter
Copy link

Codecov Report

Merging #188 (2a4247f) into main (2d25c3e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   59.40%   59.40%   -0.01%     
==========================================
  Files        1180     1180              
  Lines       72354    72352       -2     
  Branches    14978    14977       -1     
==========================================
- Hits        42983    42980       -3     
- Misses      26768    26769       +1     
  Partials     2603     2603              
Impacted Files Coverage Δ
...kages/theme/src/browser/workbench.theme.service.ts 72.20% <100.00%> (-0.17%) ⬇️
packages/theme/src/browser/theme-data.ts 63.30% <0.00%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d25c3e...2a4247f. Read the comment docs.

@erha19 erha19 requested a review from ensorrow December 22, 2021 13:56
Copy link
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit f355ca8 into main Dec 24, 2021
@erha19 erha19 deleted the fix/remove-unnecessary-theme-fallback branch December 24, 2021 07:16
Aaaaash added a commit that referenced this pull request Dec 27, 2021
erha19 pushed a commit that referenced this pull request Dec 27, 2021
* fix: add ExtensionDidContributes event for themes (#214)

* fix: remove theme fallback logic (#188)
erha19 added a commit that referenced this pull request Dec 28, 2021
* feat: support component cdn type configuration (#154)

* feat: support component cdn type configuration

* chore: add release branch to workflow

* chore: fix lint error

* chore: 2.13.2

* fix: set correct component cdn url (#158)

* chore: 2.13.3

* fix: editor save issue (#189)

* chore: 2.13.4

* fix: use temp uri to build storage path while workspace is undefined (#210)

* chore: 2.13.5

* fix: theme fallback logic (#220)

* fix: add ExtensionDidContributes event for themes (#214)

* fix: remove theme fallback logic (#188)

* chore: 2.13.6

Co-authored-by: 大表哥 <xubing.bxb@alibaba-inc.com>
erha19 added a commit that referenced this pull request Dec 29, 2021
* feat: support component cdn type configuration (#154)

* feat: support component cdn type configuration

* chore: add release branch to workflow

* chore: fix lint error

* chore: 2.13.2

* fix: set correct component cdn url (#158)

* chore: 2.13.3

* fix: editor save issue (#189)

* chore: 2.13.4

* fix: use temp uri to build storage path while workspace is undefined (#210)

* chore: 2.13.5

* fix: theme fallback logic (#220)

* fix: add ExtensionDidContributes event for themes (#214)

* fix: remove theme fallback logic (#188)

* chore: 2.13.6

Co-authored-by: 大表哥 <xubing.bxb@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants