-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid multi ServerApp instance share one path handler #3887
Conversation
🚅 Previously deployed to Railway in the core project. Environment has been deleted. |
Walkthrough本次更改主要集中在增强通道处理和依赖注入机制上。通过引入 Changes
Sequence Diagram(s)sequenceDiagram
participant A as Client
participant B as Server
participant C as CommonChannelPathHandler
A->>B: 发送请求
B->>C: 处理通道路径
C-->>B: 返回通道路径
B-->>A: 返回响应
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3887 +/- ##
=======================================
Coverage 54.84% 54.85%
=======================================
Files 1558 1558
Lines 95097 95110 +13
Branches 19487 19489 +2
=======================================
+ Hits 52156 52168 +12
- Misses 35669 35670 +1
Partials 7272 7272
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Types
Background or solution
应该是每个 ServerApp 实例创建一个 CommonChannelPathHandler 这个类。
原来是多个 ServerApp 共享一个 CommonChannelPathHandler 类了。
在 Codeblitz 上就会出现创建一次 ClientApp 时会触发后端所有的 ServerApp 的响应。
Changelog
avoid multi ServerApp instance share one path handler
Summary by CodeRabbit
新特性
CommonChannelPathHandler
以增强通道路径处理能力。ServerApp
以支持依赖注入的连接提供者。修复
文档
重构