Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support VSCode API: DocumentDropEdit #4213

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

bk1012
Copy link
Member

@bk1012 bk1012 commented Dec 11, 2024

Types

  • 🎉 New Features

Background or solution

相关代码在 #4136 这里空实现了,这里补个类型

Changelog

Summary by CodeRabbit

  • 新功能

    • 引入了 DocumentDropEdit 类,用于处理文本编辑器中的拖放内容。
    • 更新了 DocumentDropEditProvider 接口,增加了 provideDocumentDropEdits 方法,以支持内容的拖放编辑。
  • 变更

    • 移除了 DocumentDropEdit 接口中的 handledMimeType 属性。

@opensumi opensumi bot added the 🎨 feature feature required label Dec 11, 2024
Copy link
Contributor

coderabbitai bot commented Dec 11, 2024

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

warning eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning eslint > @humanwhocodes/config-array@0.13.0: Use @eslint/config-array instead
warning eslint > @humanwhocodes/config-array > @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
warning eslint > file-entry-cache > flat-cache > rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob@7.2.3: Glob versions prior to v9 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob > inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning eslint-import-resolver-typescript > glob@7.2.3: Glob versions prior to v9 are no longer supported
error Couldn't find any versions for "@opensumi/ide-dev-tool" that matches "workspace:*"

Walkthrough

此拉取请求引入了一个新的类 DocumentDropEdit,并修改了 vscode 模块中的 DocumentDropEditProvider 接口。DocumentDropEdit 类封装了用户在文本编辑器中拖放内容时发生的编辑操作的详细信息,包括要插入的文本和可选的附加编辑属性。DocumentDropEditProvider 接口更新了一个新方法 provideDocumentDropEdits,用于提供插入拖放内容的编辑。这些更改增强了编辑器中与拖放操作相关的功能。

Changes

文件路径 更改摘要
packages/types/vscode/typings/vscode.d.ts 添加类 DocumentDropEdit,并在 DocumentDropEditProvider 接口中添加方法 provideDocumentDropEdits
packages/types/vscode/typings/vscode.proposed.dropMetadata.d.ts DocumentDropEdit 接口中移除属性 handledMimeType

Possibly related PRs

Suggested labels

🎨 feature

Suggested reviewers

  • Ricbet

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 01363d9 and 7f57bc4.

📒 Files selected for processing (2)
  • packages/types/vscode/typings/vscode.d.ts (1 hunks)
  • packages/types/vscode/typings/vscode.proposed.dropMetadata.d.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • packages/types/vscode/typings/vscode.proposed.dropMetadata.d.ts

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.02%. Comparing base (01363d9) to head (7f57bc4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4213   +/-   ##
=======================================
  Coverage   54.02%   54.02%           
=======================================
  Files        1616     1616           
  Lines       98044    98044           
  Branches    20063    20063           
=======================================
+ Hits        52967    52969    +2     
+ Misses      37451    37450    -1     
+ Partials     7626     7625    -1     
Flag Coverage Δ
jsdom 49.60% <ø> (+<0.01%) ⬆️
node 15.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bk1012 bk1012 merged commit 1c8a623 into main Dec 11, 2024
14 checks passed
@bk1012 bk1012 deleted the feat/support-DocumentDropEdit branch December 11, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants