-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support VSCode API: DocumentDropEdit #4213
Conversation
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
warning eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options. Walkthrough此拉取请求引入了一个新的类 Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
packages/types/vscode/typings/vscode.d.ts
(1 hunks)packages/types/vscode/typings/vscode.proposed.dropMetadata.d.ts
(0 hunks)
💤 Files with no reviewable changes (1)
- packages/types/vscode/typings/vscode.proposed.dropMetadata.d.ts
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4213 +/- ##
=======================================
Coverage 54.02% 54.02%
=======================================
Files 1616 1616
Lines 98044 98044
Branches 20063 20063
=======================================
+ Hits 52967 52969 +2
+ Misses 37451 37450 -1
+ Partials 7626 7625 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Types
Background or solution
相关代码在 #4136 这里空实现了,这里补个类型
Changelog
Summary by CodeRabbit
新功能
DocumentDropEdit
类,用于处理文本编辑器中的拖放内容。DocumentDropEditProvider
接口,增加了provideDocumentDropEdits
方法,以支持内容的拖放编辑。变更
DocumentDropEdit
接口中的handledMimeType
属性。