feat: support VSCode API: TextEditorLineNumbersStyle.Interval #4216
Conversation
|
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
warning eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options. Walkthrough该拉取请求对 Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
packages/extension/src/common/vscode/ext-types.ts (1)
989-989: 建议为新的枚举值添加文档注释为了保持与其他枚举值的一致性和代码可读性，建议为
Interval添加类似于其他枚举值的文档注释，说明其用途。建议添加如下注释:
Relative = 2, + /** + * 按间隔显示行号。 + */ Interval = 3,
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (5)
packages/extension/src/browser/vscode/api/main.thread.editor.ts(1 hunks)packages/extension/src/common/vscode/converter.ts(2 hunks)packages/extension/src/common/vscode/ext-types.ts(1 hunks)packages/types/sumi-worker/worker.editor.d.ts(1 hunks)packages/types/vscode/typings/vscode.editor.d.ts(1 hunks)
🔇 Additional comments (4)
packages/types/sumi-worker/worker.editor.d.ts (1)
127-130: 新增的行号显示样式实现正确！
枚举值的添加符合 VSCode API 规范，注释清晰地说明了每隔 10 行显示行号的功能。
packages/extension/src/browser/vscode/api/main.thread.editor.ts (1)
519-529: 行号间隔显示模式的实现完整且正确！
switch 语句中正确处理了新增的 interval 选项，与 TextEditorLineNumbersStyle 枚举的更新保持一致。
packages/types/vscode/typings/vscode.editor.d.ts (1)
127-130: VSCode API 类型定义更新正确！
TextEditorLineNumbersStyle 枚举中新增的 Interval 选项定义完整，注释准确描述了每隔 10 行显示行号的功能。
packages/extension/src/common/vscode/converter.ts (1)
720-721: 转换器实现正确且完整
TextEditorLineNumbersStyle 命名空间中的 from() 和 to() 方法正确实现了 Interval 枚举值的双向转换，代码结构清晰。
Also applies to: 733-734
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4216 +/- ##
==========================================
- Coverage 54.02% 54.02% -0.01%
==========================================
Files 1616 1616
Lines 98044 98052 +8
Branches 20063 20058 -5
==========================================
+ Hits 52967 52970 +3
- Misses 37451 37457 +6
+ Partials 7626 7625 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Types
Background or solution
Changelog
Summary by CodeRabbit
新功能
文档