Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trigger suggest correctly while opening settings.json #889

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Apr 21, 2022

Types

  • 🐛 Bug Fixes

Background or solution

close #877

Changelog

trigger suggest correctly while opening settings.json

@erha19 erha19 force-pushed the fix/preference-settings/trigger-suggest branch from a7a9089 to 88042cb Compare April 21, 2022 17:02
@erha19 erha19 changed the title fix: trigger suggest correctly while open settings.json fix: trigger suggest correctly while opening settings.json Apr 21, 2022
@erha19 erha19 added this to the 2.17 milestone Apr 22, 2022
@erha19 erha19 force-pushed the fix/preference-settings/trigger-suggest branch from 88042cb to 7abd0b8 Compare April 22, 2022 02:13
@codecov-commenter
Copy link

Codecov Report

Merging #889 (7abd0b8) into main (11a8201) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #889      +/-   ##
==========================================
- Coverage   58.59%   58.57%   -0.02%     
==========================================
  Files        1212     1212              
  Lines       75119    75162      +43     
  Branches    15634    15642       +8     
==========================================
+ Hits        44013    44028      +15     
- Misses      28345    28374      +29     
+ Partials     2761     2760       -1     
Impacted Files Coverage Δ
packages/extension/src/common/vscode/ext-types.ts 50.14% <0.00%> (-0.60%) ⬇️
...ages/file-service/src/node/file-service-watcher.ts 68.33% <0.00%> (-0.56%) ⬇️
packages/search/src/browser/search.service.ts 40.73% <0.00%> (-0.53%) ⬇️
...erences/src/browser/preference-settings.service.ts 74.83% <0.00%> (+0.64%) ⬆️
...kages/theme/src/browser/workbench.theme.service.ts 72.05% <0.00%> (+0.88%) ⬆️
packages/monaco/src/browser/schema-registry.ts 71.11% <0.00%> (+2.22%) ⬆️
packages/core-common/src/node/port.ts 46.96% <0.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11a8201...7abd0b8. Read the comment docs.

@erha19 erha19 merged commit ade15df into main Apr 22, 2022
@erha19 erha19 deleted the fix/preference-settings/trigger-suggest branch April 22, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 在编辑器分栏情况下打开设置面板源文件可能在另外一个编辑器触发代码提示
4 participants