Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(study_locus) credible_set_qc step integration test #880

Merged
merged 6 commits into from
Oct 25, 2024

Conversation

project-defiant
Copy link
Contributor

@project-defiant project-defiant commented Oct 25, 2024

✨ Context

The CredibleSetQC step required tests to see if it works correctly.

🛠 What does this PR implement

Tests

  • Test for main functionality (repartition credible set after distributed batch jobs to predefined number of partitions).
  • Test for checking if the functionality outputs correctly credible sets with pValue lower then threshold.
  • Test for checking if the functionality outputs correctly credible sets with purityR2 higher then threshold.
  • Test for deduplication of the credible sets, while preserving the credible set with highest LogBF.

Minor changes

  • changed hardcoded study locus qc value to it's label, so concurrent updates of the value do not affect the step.
  • Save the dataset after qc step with the StudyLocus object to enforce the schema.
  • Added hydra step config .

docs

  • Added documentation of CredibleSetQCStep.

🙈 Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 25, 2024
@project-defiant project-defiant marked this pull request as ready for review October 25, 2024 16:27
Copy link
Contributor

@Daniel-Considine Daniel-Considine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me 👍

@project-defiant project-defiant merged commit 5d9d7cb into dev Oct 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Method size-M Step Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants