feat(core): Actually use KeyManager ProviderConfig [backport to release/service/v0.11] #2842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
### Proposed Changes - Looking up a key now loads the `manager` field in the key provider - This is required, as the manager should be the factory key, not the name - This allows us to load the same manager multiple times with different configs. HOWEVER the config is only looked at on the first load; we should update this so it evicts and reloads the provider if the config changes. This hopefully will come in a follow-up. Similarly, we don't have much in the way of integration tests for these, since we don't include a key manager that takes a config. I'll look into starting the Vault sample plugin back up and running. While I'm here, since our downstream deps no longer create them, I've removed support for the `KeyManagerFactory` that does *not* take a context object. ### Checklist - [x] I have added or updated unit tests - [ ] I have added or updated integration tests (if appropriate) - [ ] I have added or updated documentation ### Testing Instructions (cherry picked from commit 65ba2e0)
opentdf-automation
bot
force-pushed
the
backport-2837-to-release/service/v0.11
branch
from
a197aac to
1b0e2e1
Compare
github-actions
bot
added
comp:db
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Standard Benchmark Metrics Skipped or FailedBulk Benchmark Results
TDF3 Benchmark Results:
NANOTDF Benchmark Results:
|
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Standard Benchmark Metrics Skipped or FailedBulk Benchmark Results
TDF3 Benchmark Results:
NANOTDF Benchmark Results:
|
Contributor
X-Test Failure Reportopentdf |
Contributor
dmihalcik-virtru
approved these changes
Oct 29, 2025
Contributor
2 similar comments
Contributor
Contributor
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Standard Benchmark Metrics Skipped or FailedBulk Benchmark Results
TDF3 Benchmark Results:
NANOTDF Benchmark Results:
|
strantalis
approved these changes
Oct 29, 2025
Contributor
c-r33d
pushed a commit
that referenced
this pull request
Oct 29, 2025
🤖 I have created a release *beep* *boop* --- ## [0.11.1](service/v0.11.0...service/v0.11.1) (2025-10-29) ### Features * **core:** Actually use KeyManager ProviderConfig [backport to release/service/v0.11] ([#2842](#2842)) ([da1c0b1](da1c0b1)) ### Bug Fixes * **authz:** handle individual resource edge cases in decisions [backport to release/service/v0.11] ([#2846](#2846)) ([a4ad9dd](a4ad9dd)) * **policy:** Return the correct total during list responses. [backport to release/service/v0.11] ([#2843](#2843)) ([ebe6469](ebe6469)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #2837 to
release/service/v0.11.