Skip to content

fix(policy): Return the correct total during list responses. [backport to release/service/v0.11] #2843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jakedoublev merged 1 commit into from
Oct 29, 2025
Merged

fix(policy): Return the correct total during list responses. [backport to release/service/v0.11] #2843

jakedoublev merged 1 commit into from
Oct 29, 2025

Conversation

@opentdf-automation
Copy link
Contributor

@opentdf-automation opentdf-automation bot commented Oct 29, 2025

Description

Backport of #2836 to release/service/v0.11.

@opentdf-automation opentdf-automation bot requested review from a team as code owners October 29, 2025 16:14
@opentdf-automation opentdf-automation bot mentioned this pull request Oct 29, 2025
Merged
3 tasks
@opentdf-automation
fix(policy): Return the correct total during list responses. (#2836)
93a2b7c 
### Proposed Changes

1.) Correct all instances where `Total` is not being calculated properly
within our list responses.

### Checklist

- [ ] I have added or updated unit tests
- [ ] I have added or updated integration tests (if appropriate)
- [ ] I have added or updated documentation

### Testing Instructions

(cherry picked from commit 5c1ec9c)
@opentdf-automation opentdf-automation bot force-pushed the backport-2836-to-release/service/v0.11 branch from 5724e52 to 93a2b7c Compare October 29, 2025 16:14
@github-actions github-actions bot added comp:db DB component comp:policy Policy Configuration ( attributes, subject mappings, resource mappings, kas registry) size/m labels Oct 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 172.425092ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 102.67233ms

Standard Benchmark Metrics Skipped or Failed

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 340.72594ms
Throughput 293.49 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 37.26074996s
Average Latency 371.000807ms
Throughput 134.19 requests/second

NANOTDF Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 26.433981007s
Average Latency 263.502012ms
Throughput 189.15 requests/second

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 210.605491ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 86.275591ms

Standard Benchmark Metrics Skipped or Failed

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 367.106244ms
Throughput 272.40 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 39.464810404s
Average Latency 392.272479ms
Throughput 126.70 requests/second

NANOTDF Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 27.86680511s
Average Latency 277.797099ms
Throughput 179.42 requests/second

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

X-Test Failure Report

opentdfplatformA8W6A5.dockerbuild
✅ java-v0.4.34
cukes-report
✅ js-v0.4.34
✅ go-v0.4.34

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

X-Test Failure Report

opentdfplatformA8W6A5.dockerbuild
✅ java-v0.4.34
cukes-report
✅ js-v0.4.34
✅ go-v0.4.34
bats-test-results
test-cases-mapping-report

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

X-Test Results

opentdfplatformR0UFP0.dockerbuild
✅ js-v0.4.34
✅ java-v0.4.34
cukes-report
✅ go-v0.4.34
bats-test-results
✅ js-5724e52daf1d631ff3cbb95b350b5af5a634bf5b
✅ java-5724e52daf1d631ff3cbb95b350b5af5a634bf5b
✅ go-5724e52daf1d631ff3cbb95b350b5af5a634bf5b

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 186.378573ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 109.961068ms

Standard Benchmark Metrics Skipped or Failed

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 378.30372ms
Throughput 264.34 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 39.061330142s
Average Latency 388.484059ms
Throughput 128.00 requests/second

NANOTDF Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 27.162353253s
Average Latency 270.631056ms
Throughput 184.08 requests/second

@c-r33d c-r33d force-pushed the backport-2836-to-release/service/v0.11 branch from 522201b to 93a2b7c Compare October 29, 2025 17:19
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

X-Test Results

opentdfplatformVPSRN7.dockerbuild
✅ java-v0.4.34
✅ js-v0.4.34
cukes-report
✅ go-v0.4.34
bats-test-results
✅ js-pull-2843
test-cases-mapping-report
✅ java-pull-2843
✅ go-pull-2843

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 181.465005ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 101.011862ms

Standard Benchmark Metrics Skipped or Failed

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 373.245623ms
Throughput 267.92 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 39.293453005s
Average Latency 391.543073ms
Throughput 127.25 requests/second

NANOTDF Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 27.472007307s
Average Latency 273.819365ms
Throughput 182.00 requests/second

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 176.706238ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 110.306415ms

Standard Benchmark Metrics Skipped or Failed

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 367.939585ms
Throughput 271.78 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 40.14067793s
Average Latency 398.886804ms
Throughput 124.56 requests/second

NANOTDF Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 28.103455838s
Average Latency 279.780255ms
Throughput 177.91 requests/second

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

X-Test Results

opentdfplatformE6K2QH.dockerbuild
✅ js-v0.4.34
✅ java-v0.4.34
cukes-report
✅ go-v0.4.34
bats-test-results
✅ js-pull-2843
test-cases-mapping-report
✅ java-pull-2843
✅ go-pull-2843

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

X-Test Results

opentdfplatformSFUICU.dockerbuild
✅ js-v0.4.34
✅ java-v0.4.34
cukes-report
✅ go-v0.4.34
bats-test-results
test-cases-mapping-report
✅ js-pull-2843
✅ java-pull-2843
✅ go-pull-2843

@jakedoublev jakedoublev merged commit ebe6469 into release/service/v0.11 Oct 29, 2025
107 of 117 checks passed
@jakedoublev jakedoublev deleted the backport-2836-to-release/service/v0.11 branch October 29, 2025 17:39
@opentdf-automation opentdf-automation bot mentioned this pull request Oct 29, 2025
Merged
c-r33d pushed a commit that referenced this pull request Oct 29, 2025
@opentdf-automation
chore(release): release service 0.11.1 (#2845)
5d14616 
🤖 I have created a release *beep* *boop*
---


##
[0.11.1](service/v0.11.0...service/v0.11.1)
(2025-10-29)


### Features

* **core:** Actually use KeyManager ProviderConfig [backport to
release/service/v0.11]
([#2842](#2842))
([da1c0b1](da1c0b1))


### Bug Fixes

* **authz:** handle individual resource edge cases in decisions
[backport to release/service/v0.11]
([#2846](#2846))
([a4ad9dd](a4ad9dd))
* **policy:** Return the correct total during list responses. [backport
to release/service/v0.11]
([#2843](#2843))
([ebe6469](ebe6469))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakedoublev jakedoublev jakedoublev approved these changes

@c-r33d c-r33d c-r33d approved these changes

Assignees

No one assigned

Labels

comp:db DB component comp:policy Policy Configuration ( attributes, subject mappings, resource mappings, kas registry) size/m

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jakedoublev @c-r33d