fix: item loaded by map decays duration when moved by player (#875)

This fix ensures that map items decay properly when moved, preventing infinite items from accumulating in the game. When a player interacts with the item by moving it, it will decay and become a common item on the map.

src/game/game.cpp

@@ -1305,6 +1305,8 @@ void Game::playerMoveItem(Player* player, const Position &fromPos, uint16_t item
 	}
 	player->cancelPush();
 
+	item->checkDecayMapItemOnMove();
+
 	g_events().eventPlayerOnItemMoved(player, item, count, fromPos, toPos, fromCylinder, toCylinder);
 }
 

src/items/item.cpp

@@ -969,6 +969,13 @@ bool Item::canBeMoved() const {
 	return isMoveable() && !hasAttribute(UNIQUEID) && (!hasAttribute(ACTIONID) || getAttribute<uint16_t>(ItemAttribute_t::ACTIONID) != IMMOVABLE_ACTION_ID);
 }
 
+void Item::checkDecayMapItemOnMove() {
+	if (getDuration() > 0 && getLoadedFromMap() && canBeMoved()) {
+		setLoadedFromMap(false);
+		startDecaying();
+	}
+}
+
 uint32_t Item::getWeight() const {
 	uint32_t baseWeight = getBaseWeight();
 	if (isStackable()) {

src/items/item.h

@@ -640,6 +640,8 @@ class Item : virtual public Thing, public ItemProperties {
 		}
 
 		void updateTileFlags();
+		bool canBeMoved() const;
+		void checkDecayMapItemOnMove();
 
 	protected:
 		Cylinder* parent = nullptr;
@@ -658,8 +660,6 @@ class Item : virtual public Thing, public ItemProperties {
 		std::string getWeightDescription(uint32_t weight) const;
 
 		friend class Decay;
-
-		bool canBeMoved() const;
 };
 
 using ItemList = std::list<Item*>;