fix: item loaded by map decays duration when moved by player #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudantas
force-pushed
the
fix-decay-map-item-on-move
branch
from
eaa55a2 to
ec837ee
Compare
dudantas
changed the title
|
SonarCloud Quality Gate failed. |
QuebradaZN
approved these changes
Feb 22, 2023
dudantas
changed the title
dudantas
changed the title
dudantas
changed the title
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
This fix ensures that map items decay properly when moved, preventing infinite items from accumulating in the game. When a player interacts with the item by moving it, it will decay and become a common item on the map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix ensures that map items decay properly when moved, preventing infinite items from accumulating in the game. When a player interacts with the item by moving it, it will decay and become a common item on the map.
Behaviour
Actual
Item not decay duration.
Expected
Item decay duration.
Type of change
How Has This Been Tested
Goto position, for example: {x = 33254, y = 31839, z = 3} (it's just for testing, it's not possible to check here with player)
Equip the item and it's go decay duration