Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventCallback #1228

Closed
2 of 5 tasks
faciliter opened this issue Jul 10, 2023 · 3 comments · Fixed by #1317
Closed
2 of 5 tasks

EventCallback #1228

faciliter opened this issue Jul 10, 2023 · 3 comments · Fixed by #1317
Labels
Status: Pending Test This PR or Issue requires more testing Type: Missing Content Content that was not yet implemented or is not following the accepted standards

Comments

@faciliter
Copy link

Priority

Missing Content

Area

  • Datapack
  • Source
  • Map
  • Other

What is missing?

EventCallback

Code of Conduct

  • I agree to follow this project's Code of Conduct
@github-actions github-actions bot added Status: Pending Test This PR or Issue requires more testing Type: Missing Content Content that was not yet implemented or is not following the accepted standards labels Jul 10, 2023
@Mirkaanks
Copy link
Contributor

Can you explain better?

@soyfabi
Copy link

soyfabi commented Jul 12, 2023

Can you explain better?

I suppose they want EventCallback to be included as forgotten server.

@dudantas
Copy link
Member

Hey there! We have a lot of several open pull requests, and we need to prioritize the most critical ones. Although your suggested task is valuable, we have to focus on higher-priority items at the moment. However, if you're interested, you can take the initiative to pull the code yourself from TFS and adapt it to Canary. Once you've done that, please create a pull request.

To ensure your pr merged, we kindly request that you thoroughly test the changes and address any potential issues that may arise. By doing so, we can merge your pull request without any problems.

Thank you for your understanding and willingness to contribute. We greatly appreciate your efforts!

@dudantas dudantas mentioned this issue Jul 28, 2023
Merged
7 tasks
dudantas added a commit that referenced this issue Aug 1, 2023
@dudantas
feat: implementation of lua/c++ event callback system (#1317)
f518fdf 
We've implemented a callback system that allows interaction between C++ code and Lua scripts. Functions defined in C++ can be sent to a Lua script, which can manipulate them and return them to the C++ code. This allows for greater flexibility and interactivity between the two code layers, allowing functions to be manipulated at runtime by the Lua script.

See the example usages in our wiki: https://github.com/opentibiabr/canary/wiki/Revscriptsys-(EventCallback)

Key changes include:

• Addition of the EventCallback class encapsulating callback functionality.
• Implementation of callback functions in the EventCallbackFunctions class.
• Registration of callback functions to the Lua interface.

Fixes #1228
@dudantas dudantas mentioned this issue Aug 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Pending Test This PR or Issue requires more testing Type: Missing Content Content that was not yet implemented or is not following the accepted standards
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: implementation of lua/c++ event callback system dudantas/canary
4 participants
@dudantas @faciliter @soyfabi @Mirkaanks