Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong message types (error message type does not exist) #1444

Merged
merged 2 commits into from
Aug 19, 2023

Conversation

luanluciano93
Copy link
Contributor

Description

I'm using a data-custom, and it doesn't contain compat.lua (in my opinion this wouldn't even exist in the canary), so with the conversion of talkactions to "data" I got error messages for non-existent message types.

Behaviour

Actual

Error message:
image

Test Configuration:

  • Server Version: Canary Main
  • Client: 13.20
  • Operating System: Windows 11

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • My changes generate no new warnings

@dudantas dudantas merged commit ba99dfe into opentibiabr:main Aug 19, 2023
@dudantas dudantas changed the title fix: error message type does not exist in date fix: wrong message types (error message type does not exist) Aug 19, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
2.3% 2.3% Duplication

@luanluciano93 luanluciano93 deleted the ajustMsgTalk branch September 8, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants