Fix stored regeneration condition not using updated vocation values #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudantas
approved these changes
Aug 30, 2021
Costallat
force-pushed
the
master
branch
4 times, most recently
from
70cfa99 to
ccd27ed
Compare
Regeneration condition is not updated on login. To verify: log-in, eat food, log-out, edit vocation regeneration amount/ticks, restart server / reload vocations, log back in - condition is using the persisted values, because upon logging in conditions are temporarily kept in storedConditionList which are added to player after placing him on map. Changes Proposed: Forcibly update regeneration after storedConditionList is applied to player.
beats-dh
force-pushed
the
Fix-stored-regeneration-condition-not-using-updated-vocation-values
branch
from
c9c5f03 to
117b26d
Compare
…g-updated-vocation-values
|
Kudos, SonarCloud Quality Gate passed!
|
Costallat
force-pushed
the
master
branch
20 times, most recently
from
29e30e0 to
55e6789
Compare
Costallat
force-pushed
the
master
branch
8 times, most recently
from
88b2e44 to
4ab42fc
Compare
dudantas
approved these changes
Oct 23, 2021
…g-updated-vocation-values
…g-updated-vocation-values
|
Kudos, SonarCloud Quality Gate passed! |
beats-dh
deleted the
Fix-stored-regeneration-condition-not-using-updated-vocation-values
branch
5 tasks
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
) Regeneration condition is not updated on login. To verify: log-in, eat food, log-out, edit vocation regeneration amount/ticks, restart server / reload vocations, log back in - condition is using the persisted values, because upon logging in conditions are temporarily kept in storedConditionList which are added to player after placing him on map.
luan
pushed a commit
that referenced
this pull request
Jul 23, 2023
luan
pushed a commit
that referenced
this pull request
Jul 27, 2023
luan
pushed a commit
that referenced
this pull request
Jul 27, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regeneration condition is not updated on login. To verify: log-in, eat food, log-out, edit vocation regeneration amount/ticks, restart server / reload vocations, log back in - condition is using the persisted values, because upon logging in conditions are temporarily kept in storedConditionList which are added to player after placing him on map.
Changes Proposed:
Forcibly update regeneration after storedConditionList is applied to player.
Credits: @marmichalski.