-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summer Update Mechanics (12.7) #9
Conversation
Your pull request is greatly appreciated, thank you |
Kudos, SonarCloud Quality Gate passed! |
70cfa99
to
ccd27ed
Compare
3a437f9
to
3f6e165
Compare
f78d253
to
3b24951
Compare
88b2e44
to
4ab42fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file included from /home/ot/teste/src/game.h:32:0,
from /home/ot/teste/src/actions.cpp:26:
/home/ot/teste/src/player.h: In member function ‘virtual uint32_t Player::getReflectPercent(CombatType_t) const’:
/home/ot/teste/src/player.h:437:11: error: ‘reflectMapPercent’ was not declared in this scope
return reflectMapPercent[combatTypeToIndex(combatType)];
^~~~~~~~~~~~~~~~~
/home/ot/teste/src/player.h: In member function ‘virtual uint32_t Player::getReflectFlat(CombatType_t) const’:
/home/ot/teste/src/player.h:440:11: error: ‘reflectMapFlat’ was not declared in this scope
return reflectMapFlat[combatTypeToIndex(combatType)];
^~~~~~~~~~~~~~
/home/ot/teste/src/player.h: In member function ‘void Player::setReflectPercent(CombatType_t, int32_t)’:
/home/ot/teste/src/player.h:444:11: error: ‘class Player’ has no member named ‘reflectMapPercent’; did you mean ‘reflectPercent’?
this->reflectMapPercent[combatTypeToIndex(combatType)] = std::max(0, this->reflectMapPercent[combatTypeToIndex(combatType)] + value);
^~~~~~~~~~~~~~~~~
/home/ot/teste/src/player.h:444:80: error: ‘class Player’ has no member named ‘reflectMapPercent’; did you mean ‘reflectPercent’?
this->reflectMapPercent[combatTypeToIndex(combatType)] = std::max(0, this->reflectMapPercent[combatTypeToIndex(combatType)] + value);
^~~~~~~~~~~~~~~~~
In file included from /home/ot/teste/src/game.h:32:0,
from /home/ot/teste/src/actions.cpp:26:
/home/ot/teste/src/player.h: In member function ‘void Player::setReflectFlat(CombatType_t, int32_t)’:
/home/ot/teste/src/player.h:447:10: error: ‘class Player’ has no member named ‘reflectMapFlat’; did you mean ‘reflectFlat’?
this->reflectMapFlat[combatTypeToIndex(combatType)] = std::max(0, this->reflectMapFlat[combatTypeToIndex(combatType)] + value);
^~~~~~~~~~~~~~
/home/ot/teste/src/player.h:447:76: error: ‘class Player’ has no member named ‘reflectMapFlat’; did you mean ‘reflectFlat’?
this->reflectMapFlat[combatTypeToIndex(combatType)] = std::max(0, this->reflectMapFlat[combatTypeToIndex(combatType)] + value);
^~~~~~~~~~~~~~
@hyresu ` - #20 0x000055555579fc08 in LuaScriptInterface::protectedCall(lua_State*, int, int) (L=L@entry=0x40000378, nargs=nargs@entry=7, nresults=nresults@entry=4) at /home/ot/otbr/src/luascript.cpp:302
|
Kudos, SonarCloud Quality Gate passed! |
This PR is stale because it has been open 45 days with no activity. |
Just tested It on OTBR |
A new pull request will open soon with these mechanics complete. |
…ing the compat folder (#9) * Remove monster spells and folder data/spells * Remove unused files, reorganize core folder and remove compat folder
Description
This pull request is intended to include the new mechanics from the Summer Update 2021 (12.7)
Type of change
Please delete options that are not relevant.
How Has This Been Tested
I tested the mechanics using the new items, you can test it as well including the following attributes on new items:
For the specialized magic levels:
"deathmagiclevelpoints"
"energymagiclevelpoints"
"earthmagiclevelpoints"
"firemagiclevelpoints"
"healingmagiclevelpoints"
"holymagiclevelpoints"
"icemagiclevelpoints"
For the incremented magic shield capacity:
"magicshieldcapacitypercent"
"magicshieldcapacityflat"
For perfect shot:
"perfectshotdamage"
"perfectshotrange"
For cleave:
"cleavepercent"
For reflect:
"reflectflatall"
"reflectpercentall"
Test Configuration:
Checklist