-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve: better player group flags management #942
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majestyotbr
approved these changes
Mar 21, 2023
835afe5
to
24ad7f2
Compare
63e199a
to
a55bddf
Compare
SonarCloud Quality Gate failed. |
murilo09
approved these changes
Mar 22, 2023
majestyotbr
approved these changes
Mar 23, 2023
This PR is stale because it has been open 45 days with no activity. |
libergod
referenced
this pull request
in libergod/canary_baiak
Apr 24, 2023
new talkactions: /hasflag playername, flagname or number /setflag playername, flagname or number /removeflag playername, flagname or number new string function: string.trimSpace(str) or string:trimSpace() documented the strings functions and moved from global.lua to string.lua
64a695a
to
54444d1
Compare
majestyotbr
approved these changes
May 7, 2023
Kudos, SonarCloud Quality Gate passed! |
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
This allows us to add or remove flags on specific players, for example, so that a certain player is not visible by a monster, or cannot drop loot at a certain time (for example, in a specific quest). Instead of the flags being determined globally, they can be set differently for each player, depending on our wishes. New talkactions: • /hasflag playername, flagname or number • /setflag playername, flagname or number • /removeflag playername, flagname or number New string function: string.trimSpace(str) or string:trimSpace() Documented the strings functions and moved from global.lua to string.lua
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows us to add or remove flags on specific players, for example, so that a certain player is not visible by a monster, or cannot drop loot at a certain time (for example, in a specific quest). Instead of the flags being determined globally, they can be set differently for each player, depending on our wishes.
Behaviour
Actual
Flags are defined globally, in groups.xml, and cannot be modified in a specific player.
Expected
We can now modify the flag in just one player, if we want.
Type of change
How Has This Been Tested
Try to add this for example in login.lua:
Change the name "Druid Sample" to the name of the player you want... When he logs in, he will have the flag of not advancing skill when attacking a monster. The same can be done to remove the flag.
Checklist