fix(input): [input] fix input disabled border style

[zzcr]

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• New Features

  • Introduced a new CSS variable for the disabled border color of the textarea component.

• Style

  • Updated the styling for the disabled state and hover effects of the textarea to ensure accurate representation of its disabled status.

[coderabbitai]

Walkthrough

The changes in this pull request involve updates to the styling of the textarea component, specifically focusing on the disabled state and hover effects. The border color for the disabled textarea has been modified to use a new CSS variable, --tv-Textarea-disabled-border-color, which is defined in the vars.less file. This update ensures that the visual representation of the disabled textarea is accurate without introducing new functionality or significant structural changes.

Changes

File Path	Change Summary
packages/theme/src/textarea/index.less	Updated border color for the disabled state and hover effects to use --tv-Textarea-disabled-border-color.
packages/theme/src/textarea/vars.less	Added new CSS variable --tv-Textarea-disabled-border-color assigned to var(--tv-color-border-disabled).

Possibly related PRs

• fix(input): [input] fix textarea disabled style error #2151: Addresses styling issues specifically related to the disabled state of textareas, aligning with the main PR's changes.
• refactor(theme): [input] refactor textarea theme vars #2281: Refactors theme variables for the textarea component, related to the variable modifications in the main PR.
• fix(input): [input] fix textarea x-design style #2076: Includes changes to the index.less file for the textarea component, focusing on width adjustments, potentially related to overall styling.

Suggested reviewers

• kagol

Poem

🐰 In the meadow where textareas play,
A border's hue brightens the day.
When disabled, it wears a new shade,
A gentle touch, in style displayed.
With colors that dance and softly blend,
Our textarea's charm will never end! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

packages/theme/src/textarea/vars.less (1)

38-39: LGTM! Consider adding a comment about usage.

The addition of --tv-Textarea-disabled-border-color is appropriate and follows the existing naming and value assignment conventions. This variable will allow for more precise control over the disabled textarea's appearance, aligning with the PR's objective.

Consider adding a brief comment about where this variable is used (e.g., in the component's main less file) to improve maintainability:

 // 文本域disabled时的边框颜色
-  --tv-Textarea-disabled-border-color: var(--tv-color-border-disabled);
+  --tv-Textarea-disabled-border-color: var(--tv-color-border-disabled); // Used in textarea/index.less for disabled state

packages/theme/src/textarea/index.less (1)

75-75: Consistent styling for disabled textarea on hover.

The change to use var(--tv-Textarea-disabled-border-color) for the hover state of a disabled textarea ensures visual consistency and prevents unintended changes on hover. This is a good improvement for user experience.

For even better consistency, consider removing the hover effect entirely for disabled textareas:

&.is-disabled {
  background-color: var(--tv-Textarea-disabled-bg-color);

  &:before {
    background-color: var(--tv-Textarea-disabled-bg-color);
  }

  &:after {
    background-color: var(--tv-Textarea-disabled-bg-color);
  }

-  &:hover {
-    border-color: var(--tv-Textarea-disabled-border-color);
-  }
}

This would ensure that there's no visual change at all when hovering over a disabled textarea, which is typically the expected behavior for disabled elements.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 35414f8 and f247ed2.

📒 Files selected for processing (2)

• packages/theme/src/textarea/index.less (2 hunks)
• packages/theme/src/textarea/vars.less (1 hunks)

🧰 Additional context used

🔇 Additional comments (2)

packages/theme/src/textarea/index.less (2)

57-57: Improved visual distinction for disabled textarea.

The change from var(--tv-Textarea-border-color) to var(--tv-Textarea-disabled-border-color) enhances the visual feedback for disabled textareas. This improves accessibility and user experience by providing a clear visual cue for the disabled state.

---

Line range hint 1-324: Summary of changes and their impact

The changes in this file focus on improving the visual distinction of disabled textareas by introducing a specific CSS variable for the disabled border color. This enhancement:

1. Improves accessibility and user experience by providing clear visual feedback for disabled states.
2. Maintains consistency across different states (normal and hover) of the disabled textarea.
3. Utilizes CSS variables, allowing for easy theming and maintenance.

These changes align well with the PR objectives and contribute to a more robust and user-friendly textarea component.