fix(button): [button] solve the problem of uneven button graphics when mixing

[shenjunjian]

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

解决button按钮对不齐和modal内容撑不开的问题

Summary by CodeRabbit

• New Features

  • Improved button styles for better alignment of icons and text.
  • Enhanced modal structure with a new content wrapper for better styling flexibility.

• Bug Fixes

  • Adjusted margins and comments for clarity in button styles.

These updates improve the visual presentation and layout consistency of buttons and modals within the application.

[coderabbitai]

Walkthrough

The changes in this pull request involve updates to the styles of the button and modal components in their respective index.less files. For the button component, new styles are added to improve the layout of buttons with icons, including adjustments to the .is-icon class. In the modal component, the class for the text element is renamed to .content, introducing a new wrapper for better organization and flexibility in styling. The modifications enhance the visual presentation and structure of both components.

Changes

File	Change Summary
packages/theme/src/button/index.less	Added new styles for button display, modified the .is-icon class to use inline-flex, and updated comments regarding margin handling for mixed content.
packages/theme/src/modal/index.less	Renamed class from .@{modal-prefix-cls}__text to .@{modal-prefix-cls}__content, introduced a new wrapper class, and adjusted styling for better structure.

Possibly related PRs

• feat(button): [button] Adapting to the SMB theme #2148: Modifies the index.less file for the button component, directly related to the changes in button styles.
• feat(button): [button] Adapting to the SMB theme #2172: Introduces new styles for the button component in index.less, focusing on layout adjustments.
• fix(button): add ghost's cssvars for button #2235: Adds new CSS variables for the ghost button state, relating to overall styling changes in the button component.
• fix(button): [button]fix error css var #2312: Addresses CSS variable definitions in the button component, relevant to styling changes.
• refactor(tag): refactor fix lost css for button,tag #2301: Introduces a new line-height property for buttons, directly related to the adjustments made in button styles.

Suggested labels

bug

Suggested reviewers

• zzcr

🐰 In the land of styles, where buttons gleam,
New layouts and icons, a designer's dream.
Modals now structured, with content so bright,
Clarity and order, a beautiful sight!
Hops of joy for the changes we see,
A whimsical dance, as happy as can be! 🌼✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

packages/theme/src/button/index.less (1)

346-348: Improved button layout for mixed content. Consider adding justify-content.

The changes to the .is-icon class effectively address the issue of uneven button graphics when mixing content. The use of inline-flex and align-items: center ensures better alignment of icons and text.

Consider adding justify-content: center; to the .is-icon class to ensure horizontal centering as well:

 &.is-icon {
   display: inline-flex;
   align-items: center;
+  justify-content: center;
 }

This addition would provide more consistent centering for various button sizes and content lengths.

Also applies to: 354-354

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between be9eff9 and b416c09.

📒 Files selected for processing (2)

• packages/theme/src/button/index.less (1 hunks)
• packages/theme/src/modal/index.less (1 hunks)

🧰 Additional context used

🔇 Additional comments (2)

packages/theme/src/modal/index.less (1)

113-120: Improved modal content structure and flexibility.

The introduction of the .@{modal-prefix-cls}__content wrapper class enhances the organization and flexibility of the modal's content area. Setting width: 100% and flex-grow: 1 ensures optimal space utilization, addressing the issue of modal content not expanding properly as mentioned in the PR objectives.

packages/theme/src/button/index.less (1)

Line range hint 1-391: Overall improvements to button styling

The changes in this file effectively address the PR objective of fixing uneven button graphics when mixing content. The modifications to the .is-icon class improve the alignment and layout of buttons with icons, enhancing the overall visual consistency of the component.

The changes are focused and do not introduce any breaking changes or negatively impact other parts of the button styling. The updated comment also improves code readability and maintainability.