fix(grid): [grid] fix amount label wrap bug #2828

gimmyhehe · 2025-01-20T06:12:35Z

PR

修复金额组件标签样式换行问题

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our Commit Message Guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

Summary by CodeRabbit

Style
- Updated .popover-left class with a fixed width of 46px
- Added break-keep utility class to improve text wrapping behavior

coderabbitai · 2025-01-20T06:12:49Z

Walkthrough

The pull request involves a modification to the LESS stylesheet in the theme-saas package, specifically targeting the .popover-left CSS class. The change replaces a responsive width utility class with a fixed 46-pixel width and adds a break-keep utility class. This adjustment appears to be a targeted styling modification for the popover component's layout.

Changes

File	Change Summary
`packages/theme-saas/src/amount/index.less`	- Changed `.popover-left` width from responsive `w-1/5` to fixed `46px` - Added `break-keep` utility class to the same selector

Suggested labels

bug

Suggested reviewers

zzcr

Possibly related PRs

fix(button): [button] solve the problem of uneven button graphics when mixing #2347: CSS styles modification for button component in index.less
fix(grid): [grid] fix checkbox border become smaller when config show… #2762: CSS styles update for grid checkbox component
fix(grid): [grid] fix style error when dynamic group header is set fixed #2789: Styling issue for dynamic group headers in grid component

Poem

🐰 A pixel-perfect popover dance,
Width fixed at forty-six, no more chance
Of stretching wide or shrinking small
Break-keep in place, standing tall
A rabbit's styling romance! 🎨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

petercat-assistant · 2025-01-20T06:12:49Z

Walkthrough

此PR修复了金额组件标签的样式换行问题，通过调整CSS样式来解决标签换行的Bug。

Changes

文件	概要
packages/theme-saas/src/amount/index.less	修改了`.popover-left`类的样式，移除了`@apply ~'w-1/5'`，并添加了`width: 46px;`和`@apply break-keep;`以修复换行问题。

petercat-assistant · 2025-01-20T06:12:51Z

packages/theme-saas/src/amount/index.less

          @apply grow-0 shrink-0 ~'basis-[auto]';
          @apply mr-2;
-          @apply ~'w-1/5';
+          width: 46px;


The change from @apply ~'w-1/5' to width: 46px; and adding @apply break-keep; seems to address the label wrapping issue. Ensure that this fixed width does not cause layout issues in different contexts or screen sizes.

Issues-translate-bot · 2025-01-20T06:12:59Z

Bot detected the issue body's language is not English, translate it automatically.

Walkthrough

This PR fixes the style wrapping problem of the amount component label, and solves the label wrapping bug by adjusting the CSS style.

Changes

Documentation	Summary
packages/theme-saas/src/amount/index.less	Modified the style of `.popover-left` class, removed `@apply ~'w-1/5''`, and added `width: 46px ;` and `@apply break-keep;` to fix line breaks.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/theme-saas/src/amount/index.less (1)
95-96: LGTM! The changes effectively address the label wrapping issue.

The fixed width and break-keep utility should prevent unwanted label wrapping, which aligns with the PR's objective.

Consider using min-width instead of a fixed width for better responsiveness with varying label lengths:
-          width: 46px;
+          @apply ~'min-w-[46px]';

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3fe493e and 2d97154.

📒 Files selected for processing (1)

packages/theme-saas/src/amount/index.less (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: PR E2E Test (pnpm test:e2e3)

fix(grid): [grid] fix amount label wrap bug

2d97154

github-actions bot added the bug Something isn't working label Jan 20, 2025

petercat-assistant bot reviewed Jan 20, 2025

View reviewed changes

coderabbitai bot reviewed Jan 20, 2025

View reviewed changes

zzcr approved these changes Jan 20, 2025

View reviewed changes

zzcr merged commit a0b4de4 into dev Jan 20, 2025
10 of 11 checks passed

kagol deleted the cgm/fix-saas-currency branch April 14, 2025 12:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(grid): [grid] fix amount label wrap bug #2828

fix(grid): [grid] fix amount label wrap bug #2828

Uh oh!

gimmyhehe commented Jan 20, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jan 20, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

petercat-assistant bot commented Jan 20, 2025

Uh oh!

petercat-assistant bot Jan 20, 2025

Uh oh!

Issues-translate-bot commented Jan 20, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix(grid): [grid] fix amount label wrap bug #2828

fix(grid): [grid] fix amount label wrap bug #2828

Uh oh!

Conversation

gimmyhehe commented Jan 20, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested labels

Suggested reviewers

Possibly related PRs

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

petercat-assistant bot commented Jan 20, 2025

Walkthrough

Changes

Uh oh!

petercat-assistant bot Jan 20, 2025

Choose a reason for hiding this comment

Uh oh!

Issues-translate-bot commented Jan 20, 2025

Walkthrough

Changes

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gimmyhehe commented Jan 20, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 20, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)