fix(grid): [grid] fix checkbox border become smaller when config show…

[gimmyhehe]

…-overflow

PR

修复当配置了show-overflow后复选框边框变小
修复前：

修复后：

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• Style
  • Updated grid checkbox icon sizing to use CSS variables for more flexible styling
  • Replaced fixed dimensions with dynamic variable-based sizing

[coderabbitai]

Walkthrough

The pull request introduces a modification to the CSS styles for the grid checkbox component in the theme package. The change replaces hardcoded dimensions with CSS variables, specifically updating the width and height of the checkbox icon to use --tv-Grid-icon-size. This approach provides more flexibility in sizing the checkbox icon by leveraging a predefined CSS variable.

Changes

File	Change Summary
packages/theme/src/grid/checkbox.less	Replaced fixed width and height values with CSS variable --tv-Grid-icon-size for checkbox icon

Possibly related PRs

• fix(checkbox): [checkbox] modify smb theme #2096: SMB theme checkbox component modifications
• refactor(checkbox): [checkbox] refactor checkbox x-design theme #2174: X-design theme checkbox component refactoring
• fix(checkbox): [checkbox] fix checkbox error theme vars #2356: Theme variables update for checkbox component
• fix(checkbox): [checkbox] fixed change event bubbling caused it to be… #2397: Checkbox input event handling improvements
• fix(grid): [grid] fix can not select first option when value is empty #2756: Grid component option selection fixes

Suggested labels

bug

Suggested reviewers

• zzcr

Poem

🐰 Checkbox dancing with grace,
Variables set its sizing pace
From fixed to flex, a stylish leap
In grid's design, no more to weep
A rabbit's touch of CSS delight! 🎨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[petercat-assistant]

Walkthrough

此PR修复了在配置show-overflow后，复选框边框变小的问题。通过调整复选框图标的宽度和高度为CSS变量--tv-Grid-icon-size，确保在不同配置下边框尺寸保持一致。

Changes

文件	概要
packages/theme/src/grid/checkbox.less	修改复选框图标的宽度和高度为CSS变量以解决边框尺寸问题

[petercat-assistant]

The change from fixed 1em to var(--tv-Grid-icon-size) for width and height ensures that the checkbox icon size is consistent with the grid's icon size settings, which should resolve the issue with the checkbox border appearing smaller when show-overflow is configured.

[Issues-translate-bot]

Bot detected the issue body's language is not English, translate it automatically.

---

Walkthrough

This PR fixes the problem that the checkbox border becomes smaller after configuring show-overflow. By adjusting the width and height of the checkbox icon to the CSS variable --tv-Grid-icon-size, ensure that the border size remains consistent under different configurations.

Changes

Documentation	Summary
packages/theme/src/grid/checkbox.less	Modify the width and height of the checkbox icon as CSS variables to solve the border size problem

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/theme/src/grid/checkbox.less (1)

33-34: Document the --tv-Grid-icon-size variable.

Consider adding documentation for the --tv-Grid-icon-size CSS variable, including:

• Its default value
• Valid units/ranges
• Its relationship with other grid variables

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 336f42f and 148c70c.

📒 Files selected for processing (1)

• packages/theme/src/grid/checkbox.less (1 hunks)

🔇 Additional comments (1)

packages/theme/src/grid/checkbox.less (1)

33-34: LGTM! Good fix for the checkbox sizing issue.

Using the CSS variable --tv-Grid-icon-size for both width and height ensures consistent checkbox dimensions, preventing the border from becoming smaller when show-overflow is enabled. This is a more maintainable approach than hardcoded values.