fix(file-upload): [file-upload] Adjust the style of the mobile-first button for uploading components #2918
Conversation
WalkthroughThe pull request adjusts styling in two Vue components. One file removes the margin class ( Changes
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
packages/vue/src/file-upload/src/mobile-first.vueOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. packages/vue/src/upload/src/mobile-first.vueOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🔇 Additional comments (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
bug
WalkthroughThis PR adjusts the styles of the mobile-first button for file-upload components in the Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| operateContent = downloadAll ? ( | ||
| <div class="hidden sm:inline-block align-middle"> | ||
| <tiny-button class="ml-2" onClick={() => downloadAll(uploadFiles)}> | ||
| <tiny-button onClick={() => downloadAll(uploadFiles)}> |
There was a problem hiding this comment.
Ensure that removing the ml-2 class does not affect the button's alignment or spacing in unintended ways across different screen sizes.
| class={[ | ||
| !displayOnly && listType === 'text' | ||
| ? `flex justify-between mt-4 mb-2 ${isBubbleMode ? 'sm:my-0' : !isShowTitle ? 'sm:mt-0' : 'sm:my-3'}` | ||
| ? `flex mt-4 mb-2 ${isBubbleMode ? 'sm:my-0' : !isShowTitle ? 'sm:mt-0' : 'sm:my-3'}` |
There was a problem hiding this comment.
Verify that removing justify-between does not disrupt the intended layout, especially in cases where elements need to be spaced apart.
| !displayOnly && | ||
| (promptTip && tipMessage ? ( | ||
| <div class="hidden sm:inline-flex sm:items-center w-full"> | ||
| <div class="hidden sm:inline-flex sm:items-center"> |
There was a problem hiding this comment.
Check that removing w-full does not cause layout issues, particularly in responsive designs where full width might be necessary.
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit