Skip to content

fix(file-upload): [file-upload] Adjust the style of the mobile-first button for uploading components #2918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2025
Merged

fix(file-upload): [file-upload] Adjust the style of the mobile-first button for uploading components #2918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vue/src/file-upload/src/mobile-first.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ export default defineComponent({
if (listType === 'text') {
operateContent = downloadAll ? (
<div class="hidden sm:inline-block align-middle">
<tiny-button class="ml-2" onClick={() => downloadAll(uploadFiles)}>
<tiny-button onClick={() => downloadAll(uploadFiles)}>
Copy link

@petercat-assistant petercat-assistant bot Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that removing the ml-2 class does not affect the button's alignment or spacing in unintended ways across different screen sizes.

<div class="flex items-center">
<icon-download />
<span class="ml-2">{t('ui.fileUpload.downloadAll')}</span>
Expand Down
6 changes: 3 additions & 3 deletions packages/vue/src/upload/src/mobile-first.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export default defineComponent({
data-tag="tiny-upload"
class={[
!displayOnly && listType === 'text'
? `flex justify-between mt-4 mb-2 ${isBubbleMode ? 'sm:my-0' : !isShowTitle ? 'sm:mt-0' : 'sm:my-3'}`
? `flex mt-4 mb-2 ${isBubbleMode ? 'sm:my-0' : !isShowTitle ? 'sm:mt-0' : 'sm:my-3'}`
Copy link

@petercat-assistant petercat-assistant bot Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify that removing justify-between does not disrupt the intended layout, especially in cases where elements need to be spaced apart.

: 'h-full',
showFileList ? 'sm:mb-3' : 'sm:mb-0'
]}>
Expand All @@ -123,14 +123,14 @@ export default defineComponent({
{state.currentBreakpoint !== 'default' &&
!displayOnly &&
(promptTip && tipMessage ? (
<div class="hidden sm:inline-flex sm:items-center w-full">
<div class="hidden sm:inline-flex sm:items-center">
Copy link

@petercat-assistant petercat-assistant bot Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check that removing w-full does not cause layout issues, particularly in responsive designs where full width might be necessary.

{uploadTrigger()}
<tiny-tooltip effect="light" content={tipMessage} placement="right" popper-options={popperConfig}>
<tiny-icon-help-circle custom-class="ml-2 cursor-pointer fill-color-icon-tertiary"></tiny-icon-help-circle>
</tiny-tooltip>
</div>
) : listType === 'text' ? (
<div class="hidden sm:inline-flex sm:items-center w-full">
<div class="hidden sm:inline-flex sm:items-center">
{uploadTrigger()}
<div
title={typeof tipMessage === 'string' ? tipMessage : ''}
Expand Down
Loading