fix(radio): [radio] Adapt to dark themes

[Youyou-smiles]

fix(radio): [radio] Adapt to dark themes

Summary by CodeRabbit

• Style
  • Enhanced the visual appearance of radio buttons in their checked and disabled states, providing improved clarity and consistency in both border and background colors.

[coderabbitai]

Walkthrough

The update in the pull request modifies two CSS custom variables within the packages/theme/src/radio/vars.less file. These changes adjust the styling for radio buttons in their checked and disabled states by changing the references for the border color and inner background color.

Changes

File	Change Summary
packages/theme/src/radio/vars.less	- Updated --tv-Radio-input-checked-disabled-border-color from var(--tv-color-bg-disabled-control-checked-1) to var(--tv-color-border-disabled) - Updated --tv-Radio-inner-checked-disabled-bg-color from var(--tv-color-bg-disabled-control-checked-1) to var(--tv-color-bg-active-control-1)

Possibly related PRs

• feat(radio): [radio] Component dark theme adaptation #2951: Involves similar modifications to the CSS variables for the radio button component's checked and disabled states.
• feat(radio): [radio] Adapting to the SMB theme #2132: Focuses on adjustments to border-related styles and CSS variables in the radio button's styling.
• refactor(radio): [radio] refactor radio theme #2181: Also updates significant CSS variable definitions and styling for the radio component.

Suggested labels

bug, enhancement

Suggested reviewers

• MomoPoppy

Poem

I'm a rabbit on a code-filled run,
Hoping for styles that shine like the sun.
Border hues and backgrounds renewed,
In every radio, a fresh look is imbued.
Hoppin' with joy for changes well-done!
🐰✨

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

packages/theme/src/radio/vars.less (2)

37-37: Update of Disabled Border Color for Dark Themes

The variable --tv-Radio-input-checked-disabled-border-color has been updated to reference var(--tv-color-border-disabled), which is more appropriate for dark theme settings. Ensure that this change is consistent with the overall design tokens used elsewhere in the dark theme adaptations.

---

47-47: Refinement of Inner Checked Disabled Background Color

The variable --tv-Radio-inner-checked-disabled-bg-color now uses var(--tv-color-bg-active-control-1), aligning the background color with active control styling under dark themes. Verify that this update provides sufficient contrast and integrates well with similar components.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1a05bd6 and f883a45.

📒 Files selected for processing (1)

• packages/theme/src/radio/vars.less (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: PR E2E Test (pnpm test:e2e3)