[Transformations] Fix vector subscript out of range in transformations

[praasz]

Details:

• Fix issue reported by MSVC Assertion failed: vector subscript out of range by skip accessing not existing parameters in RemoveMultiSubGraphOpDanglingParamsResults transformation.

Tickets:

• CVS-155258

[itikhono]

why did this test start crashing? this is not a new test, what changed?

Build openvino on windows (VS2019, Debug build) and run ov_transformations_tests, the tests are crashed with the following error:
TransformationTestsF.RemoveIfDanglingParametersFromBodiesAndInputs

[praasz]

why did this test start crashing? this is not a new test, what changed?

Build openvino on windows (VS2019, Debug build) and run ov_transformations_tests, the tests are crashed with the following error:
TransformationTestsF.RemoveIfDanglingParametersFromBodiesAndInputs

MSVC in debug mode use additional assert which make additional check e.g. if index in range or check if comparators meets some requirements. Is not visible on gcc builds.

[itikhono]

why did this test start crashing? this is not a new test, what changed?

Build openvino on windows (VS2019, Debug build) and run ov_transformations_tests, the tests are crashed with the following error:
TransformationTestsF.RemoveIfDanglingParametersFromBodiesAndInputs

MSVC in debug mode use additional assert which make additional check e.g. if index in range or check if comparators meets some requirements. Is not visible on gcc builds.

I'm trying to clarify why we didn't notice this problem earlier.
Did MSVC in debug mode always failed? MSVC in debug mode is not part of a pre or post commit, but part of some sort of extended validation, so that's why we didn't notice that?

[praasz]

why did this test start crashing? this is not a new test, what changed?

Build openvino on windows (VS2019, Debug build) and run ov_transformations_tests, the tests are crashed with the following error:
TransformationTestsF.RemoveIfDanglingParametersFromBodiesAndInputs

MSVC in debug mode use additional assert which make additional check e.g. if index in range or check if comparators meets some requirements. Is not visible on gcc builds.

I'm trying to clarify why we didn't notice this problem earlier. Did MSVC in debug mode always failed? MSVC in debug mode is not part of a pre or post commit, but part of some sort of extended validation, so that's why we didn't notice that?

Looks here is added and was not detected previously

[mryzhov]

why did this test start crashing? this is not a new test, what changed?

Build openvino on windows (VS2019, Debug build) and run ov_transformations_tests, the tests are crashed with the following error:
TransformationTestsF.RemoveIfDanglingParametersFromBodiesAndInputs

MSVC in debug mode use additional assert which make additional check e.g. if index in range or check if comparators meets some requirements. Is not visible on gcc builds.

I'm trying to clarify why we didn't notice this problem earlier. Did MSVC in debug mode always failed? MSVC in debug mode is not part of a pre or post commit, but part of some sort of extended validation, so that's why we didn't notice that?

Looks here is added and was not detected previously

We are going to include Win Debug checks in pre-commit scope, previously it was a a part of post-commit checks only and moreover it was built unproperly (as Release build), that is why issue has not been detected earlier

[itikhono]

We agreed to merge this as a temporary solution.
The issue still exists in RemoveMultiSubGraphOpDanglingParamsResults and will be investigated later

[rkazants]

@praasz, can we have a test for this case in the precommit please? This problem affects several models from TF. See https://jira.devtools.intel.com/browse/CVS-155711

@AKochin, @rnugmanx, fyi