Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Transformations] Fix vector subscript out of range in transformations #27180

Merged
merged 4 commits into from
Oct 24, 2024
Merged

[Transformations] Fix vector subscript out of range in transformations #27180

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f18be58
Fix accessing not existing parameters in
praasz Oct 22, 2024
e2ae98f
Merge branch 'master' into bug/msvc-debug-vector-subscript-out-of-ran…
praasz Oct 23, 2024
b907574
Merge branch 'master' into bug/msvc-debug-vector-subscript-out-of-ran…
praasz Oct 23, 2024
bd57abf
Update param descriptors after parameter remove only
praasz Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions ...ons/src/transformations/common_optimizations/remove_multi_subgraph_op_dangling_params.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,19 +178,21 @@ bool ov::pass::RemoveMultiSubGraphOpDanglingParamsResults::run_on_model(const st
if (std::count(std::begin(to_remove_descriptors_indexes[body_idx]),
std::end(to_remove_descriptors_indexes[body_idx]),
desc_idx) > 0) {
auto& body_param = body_params[body_in_descriptors[desc_idx]->m_body_parameter_index];
body_func->remove_parameter(body_param);
// Move all body indexes which are after these indicated by to_remove_descriptors_indexes
update_body_param_desc(body_in_descriptors,
body_in_descriptors[desc_idx]->m_body_parameter_index);
if (body_in_descriptors[desc_idx]->m_body_parameter_index < body_params.size()) {
praasz marked this conversation as resolved.
Show resolved Hide resolved
auto& body_param = body_params[body_in_descriptors[desc_idx]->m_body_parameter_index];
body_func->remove_parameter(body_param);
// Move all body indexes which are after these indicated by to_remove_descriptors_indexes
update_body_param_desc(body_in_descriptors,
body_in_descriptors[desc_idx]->m_body_parameter_index);
}
// remove dangling input of MultiSubGraphOp which was not removed earlier
auto current_input_idx = body_in_descriptors[desc_idx]->m_input_index;
auto& current_input = op_inputs[current_input_idx];
// the same input tensor can go to different input ports
if (std::count(std::begin(required_inputs_indices),
if (current_input_idx < op_inputs.size() &&
std::count(std::begin(required_inputs_indices),
std::end(required_inputs_indices),
current_input_idx) == 0 &&
std::count(std::begin(op_inputs), std::end(op_inputs), current_input) > 0) {
std::count(std::begin(op_inputs), std::end(op_inputs), op_inputs[current_input_idx]) > 0) {
op_inputs.erase(std::next(op_inputs.begin(), current_input_idx));
// Move all input indexes (in all bodies) which are after these indicated by
// to_remove_descriptors_indexes and are not used in any body
Expand Down
Loading