Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Remove unnecessary FIXME #1233

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[doc] Remove unnecessary FIXME #1233

merged 1 commit into from
Jan 17, 2025

Conversation

nyunyunyunyu
Copy link
Contributor

These places don't really need changes. The comments just note that we should be careful.

closes INT-3019
closes INT-3021

@nyunyunyunyu nyunyunyunyu requested a review from yi-sun January 17, 2025 18:43
@nyunyunyunyu nyunyunyunyu merged commit 7e86717 into main Jan 17, 2025
17 checks passed
@nyunyunyunyu nyunyunyunyu deleted the chore/remove-fixme branch January 17, 2025 18:48
Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+5 [+0.1%]) 3,414 711,180 25,509,905 - - -
fibonacci_program 6,113 1,500,137 51,505,102 - - -
regex_program (+37 [+0.2%]) 18,864 4,190,904 165,028,173 - - -
ecrecover_program (-5 [-0.2%]) 2,630 285,401 15,092,297 - - -

Commit: fd19628

Benchmark Workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants