PR for endorser support to update endpoints on ledger. #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taking Latest changes done till EOD 02/11/2021
Taking latest pull done till EOD 30/11/2021
Taking latest changes done till EOD 09 / 01 / 2022
Taking latest changes done till EOD 31/Jan/22
…get updated on ledger after endorsement from an endorser. Signed-off-by: Harsh Multani <harsh1multani@gmail.com>
Signed-off-by: Harsh Multani <harsh1multani@gmail.com>
ianco
requested changes
Jan 31, 2022
| @@ -886,7 +886,12 @@ async def get_endpoint_for_did( | |||
| return address | |||
There was a problem hiding this comment.
You'll need to make these same changes in the indy_vdr.py version of the ledger
(this is enabled when you use --wallet-type askar)
| @@ -705,6 +705,8 @@ async def set_did_endpoint( | |||
| endpoint: str, | |||
There was a problem hiding this comment.
You'll need to make these same changes in the askar.py version of the ledger
(this is enabled when you use --wallet-type askar)
|
Replaced bt PR #1696 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR that contains logic which would enable the endpoint to get updated on ledger after the endorser has signed the transaction.
The endpoints that have undergone changes are :
1.) /wallet/set-did-endpoint
2.) /wallet/did/public
These are in the /aries_cloudagent/wallet/routes.py file.
After the endpoint is updated on the ledger, it also gets updated in the wallet. The call to update it in the wallet is not included in this code, but would be implemented soon.