-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for endorser support to update endpoints on ledger. #1616
Closed
HarshMultani-AyanWorks
wants to merge
6
commits into
openwallet-foundation:main
from
HarshMultani-AyanWorks:main
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b3c70a7
Merge pull request #7 from hyperledger/main
HarshMultani-AyanWorks ae188ef
Merge pull request #8 from hyperledger/main
HarshMultani-AyanWorks 4c03b0b
Merge pull request #9 from hyperledger/main
HarshMultani-AyanWorks 2c47193
Merge pull request #10 from hyperledger/main
HarshMultani-AyanWorks b09b094
#1447 , Added support for endpoints of agent to get updated on ledger…
HarshMultani 3589cfd
#1447 Resolved black formatting issues
HarshMultani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -705,6 +705,8 @@ async def set_did_endpoint( | |
endpoint: str, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You'll need to make these same changes in the askar.py version of the ledger (this is enabled when you use |
||
ledger: BaseLedger, | ||
endpoint_type: EndpointType = None, | ||
write_ledger: bool = True, | ||
endorser_did: str = None, | ||
): | ||
""" | ||
Update the endpoint for a DID in the wallet, send to ledger if public or posted. | ||
|
@@ -738,7 +740,15 @@ async def set_did_endpoint( | |
) | ||
if not ledger.read_only: | ||
async with ledger: | ||
await ledger.update_endpoint_for_did(did, endpoint, endpoint_type) | ||
attrib_def = await ledger.update_endpoint_for_did( | ||
did, | ||
endpoint, | ||
endpoint_type, | ||
write_ledger=write_ledger, | ||
endorser_did=endorser_did, | ||
) | ||
if not write_ledger: | ||
return attrib_def | ||
|
||
await self.replace_local_did_metadata(did, metadata) | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to make these same changes in the indy_vdr.py version of the ledger
(this is enabled when you use
--wallet-type askar
)