Fix empty ServiceDecorator in OobRecord causing 422 Unprocessable Entity Error

[ff137]

Resolves #2242

[swcurran]

Errors have to do with current issue with BCovrin. Someone created some fun for us on the network. Sigh.

I’ll wait a little, as I expect the network back soon and rerun. I won’t hold it up too long…

Thanks for the contribution!

[ff137]

Setting to draft again.

I notice that in the Service definition we have:

class Service(BaseModel):
    def __init__(
...
        recipient_keys: Sequence[str] = None,
        routing_keys: Sequence[str] = None,
    ):

This means that in _service_decorator_from_service:

            recipient_keys = [
                DIDKey.from_did(did_key).public_key_b58
                for did_key in service.recipient_keys
            ]
            routing_keys = [
                DIDKey.from_did(did_key).public_key_b58
                for did_key in service.routing_keys
            ]

those operations could raise an exception if either service.recipient_keys or service.routing_keys are None (not iterable).

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[ff137]

Looking again in the Service definition, we have:

        self.recipient_keys = list(recipient_keys) if recipient_keys else []

This means my previous comment is wrong: recipient_keys won't be None. So, no additional changes necessary.

It could make sense to require at least one recipient key to be present, but that's beyond this scope of this quick bug fix.