Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty ServiceDecorator in OobRecord causing 422 Unprocessable Entity Error #2362

Merged
merged 9 commits into from
Jul 31, 2023
Merged

Fix empty ServiceDecorator in OobRecord causing 422 Unprocessable Entity Error #2362

merged 9 commits into from
Jul 31, 2023

Commits on Jul 28, 2023

  1. correct the return type to Optional[ServiceDecorator] for `_service… 

    …_decorator_from_service`

Signed-off-by: ff137 <ff137@proton.me>
    @ff137
    ff137 committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    7c70a1d View commit details
    Browse the repository at this point in the history

  2. add explicit check for type of service to handle unexpected types 

    Signed-off-by: ff137 <ff137@proton.me>
    @ff137
    ff137 committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    abf2429 View commit details
    Browse the repository at this point in the history

  3. 🎨 assign endpoint to var 

    Signed-off-by: ff137 <ff137@proton.me>
    @ff137
    ff137 committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    0bb050b View commit details
    Browse the repository at this point in the history

  4. 🎨 return None for empty endpoint 

    Signed-off-by: ff137 <ff137@proton.me>
    @ff137
    ff137 committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    521abfb View commit details
    Browse the repository at this point in the history

  5. 🎨 log warning if unexpected type is passed to method 

    Signed-off-by: ff137 <ff137@proton.me>
    @ff137
    ff137 committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    b25a63b View commit details
    Browse the repository at this point in the history

  6. add tests to ensure None is returned for empty endpoints in `_service… 

    …_decorator_from_service`

Signed-off-by: ff137 <ff137@proton.me>
    @ff137
    ff137 committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    186dcd0 View commit details
    Browse the repository at this point in the history

  7. add test to ensure invalid type is handled elegantly in `_service_dec… 

    …orator_from_service` and returns None

Signed-off-by: ff137 <ff137@proton.me>
    @ff137
    ff137 committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    525df7f View commit details
    Browse the repository at this point in the history

  8. 🎨 amend logging to be more accurate in case of empty service decorato… 

    …rs being returned

Signed-off-by: ff137 <ff137@proton.me>
    @ff137
    ff137 committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    07fceb1 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Merge branch 'main' into fix/empty-service-decorator

    @ff137
    ff137 authored Jul 31, 2023
    Configuration menu
    Copy the full SHA
    e9bf37a View commit details
    Browse the repository at this point in the history