fix: remove sensitive information from agent config toJSON() method

[jimezesinachi]

Signed-off-by: Jim Ezesinachi jim@animo.id

[jimezesinachi]

All checks passed! @blu3beri

[berendsliedrecht]

I think returning them as undefined might be confusing as you won't know whether they are actually supplied.

[berendsliedrecht]

@rapaktech Prettier is failing now :). Could you fix that? I can merge it afterwards.

[berendsliedrecht]

@TimoGlastra would this be considered a breaking change? The return type of the function is quite different now, but I don't think it is a "public method"

[TimoGlastra]

I wouldn't call this a breaking change, if you need properties from the agent config you should do so using the class methods.

This LGTM @rapaktech. I just found another place where we log keys, could you also tackle that one in this PR? It's in the WalletApi.initialize() method (Initializing wallet xxx)

BTW -- marking this as a fix over chore, as we shouldn't have logged the sensitive info in the first place

[jimezesinachi]

You got it, Timo. On it.

[codecov-commenter]

Codecov Report

Merging #1112 (00947eb) into main (6747756) will decrease coverage by 0.05%.
The diff coverage is 85.35%.

@@            Coverage Diff             @@
##             main    #1112      +/-   ##
==========================================
- Coverage   88.33%   88.28%   -0.06%     
==========================================
  Files         701      705       +4     
  Lines       16111    16399     +288     
  Branches     2597     2657      +60     
==========================================
+ Hits        14232    14478     +246     
- Misses       1872     1914      +42     
  Partials        7        7              

Impacted Files	Coverage Δ
...ges/core/src/modules/common/messages/AckMessage.ts	100.00% <ø> (ø)
...ges/core/src/modules/credentials/CredentialsApi.ts	86.91% <ø> (ø)
...les/credentials/formats/CredentialFormatService.ts	100.00% <ø> (ø)
...ntials/formats/indy/IndyCredentialFormatService.ts	87.95% <0.00%> (+0.52%)	⬆️
...s/protocol/v2/handlers/V2IssueCredentialHandler.ts	96.00% <ø> (ø)
...s/protocol/v2/handlers/V2OfferCredentialHandler.ts	67.74% <ø> (ø)
...protocol/v2/handlers/V2RequestCredentialHandler.ts	96.42% <0.00%> (ø)
...ckages/core/src/modules/dids/domain/DidDocument.ts	96.47% <ø> (ø)
packages/core/src/modules/ledger/LedgerApi.ts	97.61% <ø> (ø)
...e/src/modules/proofs/formats/ProofFormatService.ts	100.00% <ø> (ø)
... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[jimezesinachi]

I think we're good @jakubkoci