Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove sensitive information from agent config toJSON() method #1112

Merged
merged 7 commits into from
Nov 23, 2022
Merged

fix: remove sensitive information from agent config toJSON() method #1112

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
58529df
chore: remove PII from agent config toJSON() method
jimezesinachi Nov 21, 2022
3fef89c
fix: add logLevel
jimezesinachi Nov 21, 2022
f7d246e
chore: removed comment
jimezesinachi Nov 21, 2022
427071e
Update packages/core/src/agent/AgentConfig.ts
jimezesinachi Nov 21, 2022
1ac70c0
refactor: to JSON to show [omitted..]
jimezesinachi Nov 21, 2022
9de244e
fix: removed PII debug log from WalletApi.initialize()
jimezesinachi Nov 22, 2022
00947eb
fix: replaced PII with asterisks
jimezesinachi Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/core/src/agent/AgentConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,16 @@ export class AgentConfig {
public toJSON() {
return {
...this.initConfig,
logger: this.logger !== undefined,
agentDependencies: this.agentDependencies != undefined,
walletConfig: {
...this.walletConfig,
key: this.walletConfig?.key ? '[omitted...]' : undefined,
storage: {
...this.walletConfig?.storage,
credentials: this.walletConfig?.storage?.credentials ? '[omitted...]' : undefined,
jimezesinachi marked this conversation as resolved.
Show resolved Hide resolved
},
},
logger: this.logger.logLevel,
agentDependencies: Boolean(this.agentDependencies),
label: this.label,
}
}
Expand Down