feat(anoncreds): legacy indy proof format service

[TimoGlastra]

Adds a LegacyIndyProofFormatService that can be used with v1 and v2 of the proof protocol.

I've made some improvements to the tails handling and it now verifies the hash after downloading.

There's some high level tests that use both the legacy indy credential format service and the legacy indy proof format service to do the full flow of issuance and verification. It's a bit hard to test in isolation with the indy-sdk, but we can change that once we have the AnonCredsRs backend.

Dependant on #1279

[codecov-commenter]

Codecov Report

Merging #1283 (645876d) into main (dfb3eaf) will increase coverage by 0.89%.
The diff coverage is 76.39%.

@@            Coverage Diff             @@
##             main    #1283      +/-   ##
==========================================
+ Coverage   85.35%   86.24%   +0.89%     
==========================================
  Files         796      813      +17     
  Lines       19347    19911     +564     
  Branches     3275     3403     +128     
==========================================
+ Hits        16513    17172     +659     
+ Misses       2634     2555      -79     
+ Partials      200      184      -16     

Impacted Files	Coverage Δ
...anoncreds/src/services/AnonCredsVerifierService.ts	100.00% <ø> (ø)
packages/core/src/index.ts	100.00% <ø> (ø)
...s/credentials/models/CredentialPreviewAttribute.ts	86.66% <ø> (ø)
packages/anoncreds/src/utils/tails.ts	18.18% <18.18%> (ø)
...noncreds/src/models/AnonCredsRevocationInterval.ts	50.00% <50.00%> (ø)
...s/src/formats/LegacyIndyCredentialFormatService.ts	65.71% <57.14%> (+0.74%)	⬆️
...ncreds/src/formats/LegacyIndyProofFormatService.ts	63.63% <63.63%> (ø)
packages/anoncreds/src/utils/credential.ts	77.94% <71.42%> (+1.12%)	⬆️
...ages/anoncreds/src/models/AnonCredsProofRequest.ts	71.87% <71.87%> (ø)
...reds-rs/src/services/AnonCredsRsVerifierService.ts	78.26% <75.00%> (ø)
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[genaris]

I liked the usage of the modern satisfied operator, making worthy the recent upgrade to TypeScript 4.9 😛

I found a few issues when integrating it with Askar/AnonCredsRs but I think they are not related to changes on this PR, so surely will be part of a fix PR once I debug it more.

[genaris]

I know this comes from the spec but it seems to me that will be very confusing:

• ver is an optional string, specifying the presentation request version
• version is a string set by the verifier, the version of the presentation request

[TimoGlastra]

Yup that's very weird. We don't expose them in the AFJ API as 2.0 is the default I think when you don't provide it

[TimoGlastra]

I liked the usage of the modern satisfied operator, making worthy the recent upgrade to TypeScript 4.9 😛

Yup really like the operator. It's often exactly what you need: verify something conforms to a type

[genaris]

I liked the usage of the modern satisfied operator, making worthy the recent upgrade to TypeScript 4.9 stuck_out_tongue

Yup really like the operator. It's often exactly what you need: verify something conforms to a type

When running an e2e test using anoncreds-rs I'm experiencing an issue that maybe it's related to this. I create a present proof much in the same way than presentProof function in packages/core/tests/helpers.ts (but using v1 protocol instead of v2).

Logging the proof request object that AnonCredsRsHolderService.createProof() receives, I see the following:

{"name":"test-proof-request",
"version":"1.0",
"nonce":"928479155009903779791520",
"requested_attributes":{
  "name":{
     "name":"name",
     "restrictions":[{"credentialDefinitionId":"TL1EaPFCZ8Si5aUrqScBDt:3:CL:15449:Employee Credential"}]}},
"requested_predicates":{}}

Note that camelCase in credentialDefinitionId, when AnonCredsRestriction model uses cred_def_id. Are we somewhere missing a JSONTransformer.toJSON()?

[TimoGlastra]

Are you already using the LegacyIndyProofFormatService from this PR?